From: Herbert Xu <herbert@gondor.apana.org.au>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Eric Biggers <ebiggers@kernel.org>,
linux-crypto@vger.kernel.org, linux-s390@vger.kernel.org,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Harald Freudenberger <freude@linux.ibm.com>
Subject: Re: [RFT PATCH 0/3] crypto: s390 - convert to skcipher API
Date: Wed, 16 Oct 2019 23:35:07 +1100 [thread overview]
Message-ID: <20191016123507.GA16265@gondor.apana.org.au> (raw)
In-Reply-To: <20191016080103.GA4267@osiris>
On Wed, Oct 16, 2019 at 10:01:03AM +0200, Heiko Carstens wrote:
> On Sat, Oct 12, 2019 at 01:18:06PM -0700, Eric Biggers wrote:
> > This series converts the glue code for the S390 CPACF implementations of
> > AES, DES, and 3DES modes from the deprecated "blkcipher" API to the
> > "skcipher" API. This is needed in order for the blkcipher API to be
> > removed.
> >
> > I've compiled this patchset, and the conversion is very similar to that
> > which has been done for many other crypto drivers. But I don't have the
> > hardware to test it, nor is S390 CPACF supported by QEMU. So I really
> > need someone with the hardware to test it. You can do so by setting:
>
> ...
>
> > Eric Biggers (3):
> > crypto: s390/aes - convert to skcipher API
> > crypto: s390/paes - convert to skcipher API
> > crypto: s390/des - convert to skcipher API
> >
> > arch/s390/crypto/aes_s390.c | 609 ++++++++++++++---------------------
> > arch/s390/crypto/des_s390.c | 419 ++++++++++--------------
> > arch/s390/crypto/paes_s390.c | 414 ++++++++++--------------
> > 3 files changed, 580 insertions(+), 862 deletions(-)
>
> Herbert, should these go upstream via the s390 or crypto tree?
It would be best to go via the crypto tree since any future patches
to remove blkcipher/ablkcipher would depend on these patches.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2019-10-16 12:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-12 20:18 [RFT PATCH 0/3] crypto: s390 - convert to skcipher API Eric Biggers
2019-10-12 20:18 ` [RFT PATCH 1/3] crypto: s390/aes " Eric Biggers
2019-10-15 11:11 ` Harald Freudenberger
2019-10-12 20:18 ` [RFT PATCH 2/3] crypto: s390/paes " Eric Biggers
2019-10-15 11:31 ` Harald Freudenberger
2019-10-16 17:05 ` Eric Biggers
2019-10-17 14:05 ` Harald Freudenberger
2019-10-12 20:18 ` [RFT PATCH 3/3] crypto: s390/des " Eric Biggers
2019-10-15 10:14 ` Harald Freudenberger
2019-10-14 9:41 ` [RFT PATCH 0/3] crypto: s390 " Harald Freudenberger
2019-10-14 12:46 ` Ard Biesheuvel
2019-10-16 8:01 ` Heiko Carstens
2019-10-16 12:35 ` Herbert Xu [this message]
2019-10-17 9:00 ` Heiko Carstens
2019-10-16 9:02 ` Gilad Ben-Yossef
2019-10-18 8:05 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191016123507.GA16265@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=borntraeger@de.ibm.com \
--cc=ebiggers@kernel.org \
--cc=freude@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).