From: Eric Biggers <ebiggers@kernel.org>
To: linux-crypto@vger.kernel.org
Subject: [PATCH 0/5] crypto: remove blkcipher
Date: Fri, 25 Oct 2019 12:41:08 -0700 [thread overview]
Message-ID: <20191025194113.217451-1-ebiggers@kernel.org> (raw)
Now that all "blkcipher" algorithms have been converted to "skcipher",
this series removes the blkcipher algorithm type.
The skcipher (symmetric key cipher) algorithm type was introduced a few
years ago to replace both blkcipher and ablkcipher (synchronous and
asynchronous block cipher). The advantages of skcipher include:
- A much less confusing name, since none of these algorithm types have
ever actually been for raw block ciphers, but rather for all
length-preserving encryption modes including block cipher modes of
operation, stream ciphers, and other length-preserving modes.
- It unified blkcipher and ablkcipher into a single algorithm type
which supports both synchronous and asynchronous implementations.
Note, blkcipher already operated only on scatterlists, so the fact
that skcipher does too isn't a regression in functionality.
- Better type safety by using struct skcipher_alg, struct
crypto_skcipher, etc. instead of crypto_alg, crypto_tfm, etc.
- It sometimes simplifies the implementations of algorithms.
Also, the blkcipher API was no longer being tested.
Eric Biggers (5):
crypto: unify the crypto_has_skcipher*() functions
crypto: remove crypto_has_ablkcipher()
crypto: rename crypto_skcipher_type2 to crypto_skcipher_type
crypto: remove the "blkcipher" algorithm type
crypto: rename the crypto_blkcipher module and kconfig option
Documentation/crypto/api-skcipher.rst | 13 +-
Documentation/crypto/architecture.rst | 2 -
Documentation/crypto/devel-algos.rst | 27 +-
arch/arm/crypto/Kconfig | 6 +-
arch/arm64/crypto/Kconfig | 8 +-
crypto/Kconfig | 84 ++--
crypto/Makefile | 7 +-
crypto/api.c | 2 +-
crypto/blkcipher.c | 548 --------------------------
crypto/cryptd.c | 2 +-
crypto/crypto_user_stat.c | 4 -
crypto/essiv.c | 6 +-
crypto/skcipher.c | 124 +-----
drivers/crypto/Kconfig | 52 +--
drivers/crypto/amlogic/Kconfig | 2 +-
drivers/crypto/caam/Kconfig | 6 +-
drivers/crypto/cavium/nitrox/Kconfig | 2 +-
drivers/crypto/ccp/Kconfig | 2 +-
drivers/crypto/hisilicon/Kconfig | 2 +-
drivers/crypto/qat/Kconfig | 2 +-
drivers/crypto/ux500/Kconfig | 2 +-
drivers/crypto/virtio/Kconfig | 2 +-
drivers/net/wireless/cisco/Kconfig | 2 +-
include/crypto/algapi.h | 74 ----
include/crypto/internal/skcipher.h | 12 -
include/crypto/skcipher.h | 27 +-
include/linux/crypto.h | 426 +-------------------
net/bluetooth/Kconfig | 2 +-
net/rxrpc/Kconfig | 2 +-
net/xfrm/Kconfig | 2 +-
net/xfrm/xfrm_algo.c | 4 +-
31 files changed, 124 insertions(+), 1332 deletions(-)
delete mode 100644 crypto/blkcipher.c
--
2.23.0
next reply other threads:[~2019-10-25 19:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 19:41 Eric Biggers [this message]
2019-10-25 19:41 ` [PATCH 1/5] crypto: unify the crypto_has_skcipher*() functions Eric Biggers
2019-10-25 19:41 ` [PATCH 2/5] crypto: remove crypto_has_ablkcipher() Eric Biggers
2019-10-25 19:41 ` [PATCH 3/5] crypto: rename crypto_skcipher_type2 to crypto_skcipher_type Eric Biggers
2019-10-25 19:41 ` [PATCH 4/5] crypto: remove the "blkcipher" algorithm type Eric Biggers
2019-10-25 19:41 ` [PATCH 5/5] crypto: rename the crypto_blkcipher module and kconfig option Eric Biggers
2019-10-26 15:32 ` [PATCH 0/5] crypto: remove blkcipher Ard Biesheuvel
2019-10-26 16:19 ` Eric Biggers
2019-10-26 16:22 ` Ard Biesheuvel
2019-11-01 6:12 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191025194113.217451-1-ebiggers@kernel.org \
--to=ebiggers@kernel.org \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).