From: Eric Biggers <ebiggers@kernel.org>
To: Xu Zaibo <xuzaibo@huawei.com>
Cc: herbert@gondor.apana.org.au, davem@davemloft.net,
linux-crypto@vger.kernel.org, jonathan.cameron@huawei.com,
wangzhou1@hisilicon.com, linuxarm@huawei.com,
fanghao11@huawei.com, yekai13@huawei.com, zhangwei375@huawei.com,
forest.zhouchang@huawei.com
Subject: Re: [PATCH v2 0/5] crypto: hisilicon - add HiSilicon SEC V2 support
Date: Mon, 11 Nov 2019 17:28:43 -0800 [thread overview]
Message-ID: <20191112012843.GA695@sol.localdomain> (raw)
In-Reply-To: <6cecf2de-9aa0-f6ea-0c2d-8e974a1a820b@huawei.com>
On Tue, Nov 12, 2019 at 09:04:33AM +0800, Xu Zaibo wrote:
> On 2019/11/12 1:18, Eric Biggers wrote:
> > On Mon, Nov 11, 2019 at 08:26:20PM +0800, Xu Zaibo wrote:
> > > Hi,
> > >
> > > On 2019/11/11 13:37, Eric Biggers wrote:
> > > > On Mon, Nov 11, 2019 at 10:21:39AM +0800, Xu Zaibo wrote:
> > > > > Hi,
> > > > >
> > > > > On 2019/11/9 10:16, Eric Biggers wrote:
> > > > > > On Sat, Nov 09, 2019 at 10:01:52AM +0800, Zaibo Xu wrote:
> > > > > > > This series adds HiSilicon Security Engine (SEC) version 2 controller
> > > > > > > driver in Crypto subsystem. It includes PCIe enabling, Skcipher, DebugFS
> > > > > > > and SRIOV support of SEC.
> > > > > > >
> > > > > > > This patchset rebases on:
> > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git
> > > > > > >
> > > > > > > This patchset is based on:
> > > > > > > https://www.spinics.net/lists/linux-crypto/msg43520.html
> > > > > > >
> > > > > > > Changes:
> > > > > > > - delete checking return value of debugfs_create_xxx functions.
> > > > > > >
> > > > > > > Change log:
> > > > > > > v2: - remove checking return value of debugfs_create_xxx functions.
> > > > > > >
> > > > > > Does this driver pass all the crypto self-tests, including with
> > > > > > CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y?
> > > > > >
> > > > > Not including extra testing now, only CONFIG_CRYPTO_TEST is passed.
> > > > >
> > > > Can you please ensure that all the extra tests are passing too? I.e., boot a
> > > > kernel with CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y and check dmesg for failures.
> > > >
> > > Ok, I will try to do this. BTW, why we need this test? Thanks.
> > >
> > It will test the correctness of your driver.
> >
> So, it is a basic test not an extra test ? :)
>
The options are separate because the "extra tests" include fuzz tests which take
much longer to run than the regular tests, and some people who enable the
regular tests wouldn't want them to get 100x slower. But as someone actually
developing a crypto driver you're expected to run the extra tests. They've
found lots of bugs in other drivers, so please run them and fix any bugs found.
- Eric
next prev parent reply other threads:[~2019-11-12 1:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-09 2:01 [PATCH v2 0/5] crypto: hisilicon - add HiSilicon SEC V2 support Zaibo Xu
2019-11-09 2:01 ` [PATCH v2 1/5] crypto: hisilicon - add HiSilicon SEC V2 driver Zaibo Xu
2019-11-09 2:01 ` [PATCH v2 2/5] crypto: hisilicon - add SRIOV for HiSilicon SEC Zaibo Xu
2019-11-09 2:01 ` [PATCH v2 3/5] Documentation: add DebugFS doc " Zaibo Xu
2019-11-09 2:01 ` [PATCH v2 4/5] crypto: hisilicon - add DebugFS " Zaibo Xu
2019-11-09 2:01 ` [PATCH v2 5/5] MAINTAINERS: Add maintainer for HiSilicon SEC V2 driver Zaibo Xu
2019-11-09 2:16 ` [PATCH v2 0/5] crypto: hisilicon - add HiSilicon SEC V2 support Eric Biggers
2019-11-11 2:21 ` Xu Zaibo
2019-11-11 5:37 ` Eric Biggers
2019-11-11 12:26 ` Xu Zaibo
2019-11-11 17:18 ` Eric Biggers
2019-11-12 1:04 ` Xu Zaibo
2019-11-12 1:28 ` Eric Biggers [this message]
2019-11-12 2:11 ` Xu Zaibo
2019-11-12 2:33 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112012843.GA695@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=davem@davemloft.net \
--cc=fanghao11@huawei.com \
--cc=forest.zhouchang@huawei.com \
--cc=herbert@gondor.apana.org.au \
--cc=jonathan.cameron@huawei.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=wangzhou1@hisilicon.com \
--cc=xuzaibo@huawei.com \
--cc=yekai13@huawei.com \
--cc=zhangwei375@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).