From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1421C54FCE for ; Mon, 23 Mar 2020 06:31:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D331720736 for ; Mon, 23 Mar 2020 06:31:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725930AbgCWGbU (ORCPT ); Mon, 23 Mar 2020 02:31:20 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:56950 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726059AbgCWGbU (ORCPT ); Mon, 23 Mar 2020 02:31:20 -0400 Received: from gwarestrin.me.apana.org.au ([192.168.0.7] helo=gwarestrin.arnor.me.apana.org.au) by fornost.hmeau.com with smtp (Exim 4.89 #2 (Debian)) id 1jGGbv-0004YR-OH; Mon, 23 Mar 2020 17:30:56 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Mon, 23 Mar 2020 17:30:55 +1100 Date: Mon, 23 Mar 2020 17:30:55 +1100 From: Herbert Xu To: Haren Myneni Cc: mpe@ellerman.id.au, dja@axtens.net, mikey@neuling.org, sukadev@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org, linux-crypto@vger.kernel.org, npiggin@gmail.com Subject: Re: [PATCH v4 4/9] crypto/nx: Initialize coproc entry with kzalloc Message-ID: <20200323063055.GA5932@gondor.apana.org.au> References: <1584934879.9256.15321.camel@hbabu-laptop> <1584936180.9256.15326.camel@hbabu-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1584936180.9256.15326.camel@hbabu-laptop> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sun, Mar 22, 2020 at 09:03:00PM -0700, Haren Myneni wrote: > > coproc entry is initialized during NX probe on power9, but not on P8. > nx842_delete_coprocs() is used for both and frees receive window if it > is allocated. Getting crash for rmmod on P8 since coproc->vas.rxwin > is not initialized. > > This patch replaces kmalloc with kzalloc in nx842_powernv_probe() > > Signed-off-by: Haren Myneni > --- > drivers/crypto/nx/nx-842-powernv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Herbert Xu -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt