From: Herbert Xu <herbert@gondor.apana.org.au>
To: Eric Biggers <ebiggers@kernel.org>,
Nick Terrell <terrelln@fb.com>, Chris Mason <clm@fb.com>
Cc: linux-crypto@vger.kernel.org, Nikolay Borisov <nborisov@suse.com>
Subject: Re: [PATCH] lib/xxhash: make xxh{32,64}_update() return void
Date: Tue, 19 May 2020 14:38:22 +1000 [thread overview]
Message-ID: <20200519043822.GA26368@gondor.apana.org.au> (raw)
In-Reply-To: <20200515191516.GD1009@sol.localdomain>
On Fri, May 15, 2020 at 12:15:16PM -0700, Eric Biggers wrote:
> On Fri, May 01, 2020 at 11:34:23PM -0700, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@google.com>
> >
> > The return value of xxh64_update() is pointless and confusing, since an
> > error is only returned for input==NULL. But the callers must ignore
> > this error because they might pass input=NULL, length=0.
> >
> > Likewise for xxh32_update().
> >
> > Just make these functions return void.
> >
> > Cc: Nikolay Borisov <nborisov@suse.com>
> > Signed-off-by: Eric Biggers <ebiggers@google.com>
> > ---
> >
> > lib/xxhash.c doesn't actually have a maintainer, but probably it makes
> > sense to take this through the crypto tree, alongside the other patch I
> > sent to return void in lib/crypto/sha256.c.
>
> Herbert, are you planning to apply this patch?
It looks like Chris Mason added this originally. Chris, are you
OK with this patch and if so do you want to take it or shall I
push it through the crypto tree?
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2020-05-19 4:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-02 6:34 [PATCH] lib/xxhash: make xxh{32,64}_update() return void Eric Biggers
2020-05-02 8:01 ` Nikolay Borisov
2020-05-02 16:46 ` Eric Biggers
2020-05-15 19:15 ` Eric Biggers
2020-05-19 4:38 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200519043822.GA26368@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=clm@fb.com \
--cc=ebiggers@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=nborisov@suse.com \
--cc=terrelln@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).