From: David Miller <davem@davemloft.net>
To: poojatrivedi@gmail.com
Cc: borisp@mellanox.com, aviadye@mellanox.com,
john.fastabend@gmail.com, daniel@iogearbox.net, kuba@kernel.org,
vakul.garg@nxp.com, netdev@vger.kernel.org,
linux-crypto@vger.kernel.org,
mallesham.jatharkonda@oneconvergence.com,
josh.tway@stackpath.com, pooja.trivedi@stackpath.com
Subject: Re: [PATCH net] net/tls(TLS_SW): Add selftest for 'chunked' sendfile test
Date: Mon, 08 Jun 2020 19:02:13 -0700 (PDT) [thread overview]
Message-ID: <20200608.190213.2930972358973149.davem@davemloft.net> (raw)
In-Reply-To: <1591372878-10314-1-git-send-email-pooja.trivedi@stackpath.com>
From: Pooja Trivedi <poojatrivedi@gmail.com>
Date: Fri, 5 Jun 2020 16:01:18 +0000
> This selftest tests for cases where sendfile's 'count'
> parameter is provided with a size greater than the intended
> file size.
>
> Motivation: When sendfile is provided with 'count' parameter
> value that is greater than the size of the file, kTLS example
> fails to send the file correctly. Last chunk of the file is
> not sent, and the data integrity is compromised.
> The reason is that the last chunk has MSG_MORE flag set
> because of which it gets added to pending records, but is
> not pushed.
> Note that if user space were to send SSL_shutdown control
> message, pending records would get flushed and the issue
> would not happen. So a shutdown control message following
> sendfile can mask the issue.
>
> Signed-off-by: Pooja Trivedi <pooja.trivedi@stackpath.com>
> Signed-off-by: Mallesham Jatharkonda <mallesham.jatharkonda@oneconvergence.com>
> Signed-off-by: Josh Tway <josh.tway@stackpath.com>
Applied, thank you.
prev parent reply other threads:[~2020-06-09 2:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 16:01 [PATCH net] net/tls(TLS_SW): Add selftest for 'chunked' sendfile test Pooja Trivedi
2020-06-06 0:27 ` Jakub Kicinski
2020-06-09 2:02 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200608.190213.2930972358973149.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aviadye@mellanox.com \
--cc=borisp@mellanox.com \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=josh.tway@stackpath.com \
--cc=kuba@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=mallesham.jatharkonda@oneconvergence.com \
--cc=netdev@vger.kernel.org \
--cc=pooja.trivedi@stackpath.com \
--cc=poojatrivedi@gmail.com \
--cc=vakul.garg@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).