From: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
To: herbert@gondor.apana.org.au
Cc: linux-crypto@vger.kernel.org, qat-linux@intel.com,
Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Subject: [PATCH v3 0/4] crypto: qat - fixes to aes xts
Date: Mon, 29 Jun 2020 18:16:16 +0100 [thread overview]
Message-ID: <20200629171620.2989-1-giovanni.cabiddu@intel.com> (raw)
This series fixes a few issues with the xts(aes) implementation in the
QuickAssist driver:
- Requests that are not multiple of the block size are rejected
- Input key not validated
- xts(aes) requests with key size 192 bits are rejected with -EINVAL
Changes from v2:
- Patch #4 - removed CRYPTO_ALG_ASYNC flag from mask in the allocation
of the fallback tfm to allow asynchronous implementations as fallback.
- Patch #4 - added CRYPTO_ALG_NEED_FALLBACK flag as mask when allocating
fallback tfm to avoid implementations that require fallback.
- Reworked commit messages to have system logs in one line.
Changes from v1:
- Removed extra pair of parenthesis around PTR_ERR in patch #4 (crypto:
qat - allow xts requests not multiple of block)
Giovanni Cabiddu (4):
crypto: qat - allow xts requests not multiple of block
crypto: qat - validate xts key
crypto: qat - remove unused field in skcipher ctx
crypto: qat - fallback for xts with 192 bit keys
drivers/crypto/qat/qat_common/qat_algs.c | 98 ++++++++++++++++++++++--
1 file changed, 90 insertions(+), 8 deletions(-)
--
2.26.2
next reply other threads:[~2020-06-29 19:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 17:16 Giovanni Cabiddu [this message]
2020-06-29 17:16 ` [PATCH v3 1/4] crypto: qat - allow xts requests not multiple of block Giovanni Cabiddu
2020-06-29 17:16 ` [PATCH v3 2/4] crypto: qat - validate xts key Giovanni Cabiddu
2020-06-29 17:16 ` [PATCH v3 3/4] crypto: qat - remove unused field in skcipher ctx Giovanni Cabiddu
2020-06-29 17:16 ` [PATCH v3 4/4] crypto: qat - fallback for xts with 192 bit keys Giovanni Cabiddu
2020-07-09 12:53 ` [PATCH v3 0/4] crypto: qat - fixes to aes xts Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200629171620.2989-1-giovanni.cabiddu@intel.com \
--to=giovanni.cabiddu@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=qat-linux@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).