linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sven Auhagen <sven.auhagen@voleatech.de>
To: herbert@gondor.apana.org.au
Cc: linux-crypto@vger.kernel.org
Subject: [BUG] marvell/cesa - Fix sparse warnings breaks driver
Date: Mon, 18 Jan 2021 10:18:08 +0100	[thread overview]
Message-ID: <20210118091808.3dlauqgbv5yk25oa@SvensMacbookPro.hq.voleatech.com> (raw)

Hi Herbert,

your patch crypto: marvell/cesa - Fix sparse warnings unfortunately
breaks the cesa driver.

I am using it on my Armada 388 board and with that patch
applied the self test stalls indefinitely.

I tried to find out which part of the patch but it seems
all of the different changes have beaking side effects.

Removing the swab is a breaking change as well as
introducing the dst_dma and src_dma variables.

Also on my 5.10 Kernel the hash tests are failing now
but this also happens when I remove your patch:

[    6.859791] alg: ahash: mv-hmac-md5 test failed (wrong result) on test vector 0, cfg="init+update+final aligned buffer"
[    6.883144] alg: ahash: mv-hmac-sha1 test failed (wrong result) on test vector 0, cfg="init+update+final aligned buffer"
[    6.923069] alg: ahash: mv-hmac-sha256 test failed (wrong result) on test vector 0, cfg="init+update+final aligned buffer"

You might need to revert the patch.

Let me know if I can debug it in any way.

Best
Sven


             reply	other threads:[~2021-01-18 10:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-18  9:18 Sven Auhagen [this message]
2021-01-20  5:26 ` [BUG] marvell/cesa - Fix sparse warnings breaks driver Herbert Xu
2021-01-20  5:40   ` [PATCH] crypto: marvel/cesa - Fix tdma descriptor on 64-bit Herbert Xu
2021-01-20 10:51     ` Sven Auhagen
2021-01-20  6:17   ` [BUG] marvell/cesa - Fix sparse warnings breaks driver Sven Auhagen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210118091808.3dlauqgbv5yk25oa@SvensMacbookPro.hq.voleatech.com \
    --to=sven.auhagen@voleatech.de \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).