From: Herbert Xu <herbert@gondor.apana.org.au>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: linux-crypto@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] crypto: arm64/sha - add missing module aliases
Date: Fri, 22 Jan 2021 17:20:53 +1100 [thread overview]
Message-ID: <20210122062053.GB1217@gondor.apana.org.au> (raw)
In-Reply-To: <20210114181010.17187-1-ardb@kernel.org>
On Thu, Jan 14, 2021 at 07:10:10PM +0100, Ard Biesheuvel wrote:
> The accelerated, instruction based implementations of SHA1, SHA2 and
> SHA3 are autoloaded based on CPU capabilities, given that the code is
> modest in size, and widely used, which means that resolving the algo
> name, loading all compatible modules and picking the one with the
> highest priority is taken to be suboptimal.
>
> However, if these algorithms are requested before this CPU feature
> based matching and autoloading occurs, these modules are not even
> considered, and we end up with suboptimal performance.
>
> So add the missing module aliases for the various SHA implementations.
>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> arch/arm64/crypto/sha1-ce-glue.c | 1 +
> arch/arm64/crypto/sha2-ce-glue.c | 2 ++
> arch/arm64/crypto/sha3-ce-glue.c | 4 ++++
> arch/arm64/crypto/sha512-ce-glue.c | 2 ++
> 4 files changed, 9 insertions(+)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2021-01-22 6:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 18:10 [PATCH] crypto: arm64/sha - add missing module aliases Ard Biesheuvel
2021-01-22 6:20 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210122062053.GB1217@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=ardb@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).