From: Tom Lendacky <thomas.lendacky@amd.com>
To: Eric Biggers <ebiggers@kernel.org>, linux-crypto@vger.kernel.org
Subject: Re: [PATCH 05/20] crypto: ccp - use crypto_shash_tfm_digest()
Date: Thu, 7 May 2020 16:23:29 -0500 [thread overview]
Message-ID: <2306b736-91df-3f76-0eb2-fe0308d144f2@amd.com> (raw)
In-Reply-To: <20200502053122.995648-6-ebiggers@kernel.org>
On 5/2/20 12:31 AM, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> Instead of manually allocating a 'struct shash_desc' on the stack and
> calling crypto_shash_digest(), switch to using the new helper function
> crypto_shash_tfm_digest() which does this for us.
>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Acked-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
> drivers/crypto/ccp/ccp-crypto-sha.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/crypto/ccp/ccp-crypto-sha.c b/drivers/crypto/ccp/ccp-crypto-sha.c
> index 474e6f1a6a84ec..b0cc2bd73af804 100644
> --- a/drivers/crypto/ccp/ccp-crypto-sha.c
> +++ b/drivers/crypto/ccp/ccp-crypto-sha.c
> @@ -272,9 +272,6 @@ static int ccp_sha_setkey(struct crypto_ahash *tfm, const u8 *key,
> {
> struct ccp_ctx *ctx = crypto_tfm_ctx(crypto_ahash_tfm(tfm));
> struct crypto_shash *shash = ctx->u.sha.hmac_tfm;
> -
> - SHASH_DESC_ON_STACK(sdesc, shash);
> -
> unsigned int block_size = crypto_shash_blocksize(shash);
> unsigned int digest_size = crypto_shash_digestsize(shash);
> int i, ret;
> @@ -289,10 +286,8 @@ static int ccp_sha_setkey(struct crypto_ahash *tfm, const u8 *key,
>
> if (key_len > block_size) {
> /* Must hash the input key */
> - sdesc->tfm = shash;
> -
> - ret = crypto_shash_digest(sdesc, key, key_len,
> - ctx->u.sha.key);
> + ret = crypto_shash_tfm_digest(shash, key, key_len,
> + ctx->u.sha.key);
> if (ret)
> return -EINVAL;
>
>
next prev parent reply other threads:[~2020-05-07 21:23 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-02 5:31 [PATCH 00/20] crypto: introduce crypto_shash_tfm_digest() Eric Biggers
2020-05-02 5:31 ` [PATCH 01/20] crypto: hash - " Eric Biggers
2020-05-02 5:31 ` [PATCH 02/20] crypto: arm64/aes-glue - use crypto_shash_tfm_digest() Eric Biggers
2020-05-02 5:31 ` [PATCH 03/20] crypto: essiv " Eric Biggers
2020-05-02 5:31 ` [PATCH 04/20] crypto: artpec6 " Eric Biggers
2020-05-02 5:31 ` [PATCH 05/20] crypto: ccp " Eric Biggers
2020-05-07 21:23 ` Tom Lendacky [this message]
2020-05-02 5:31 ` [PATCH 06/20] crypto: ccree " Eric Biggers
2020-05-03 14:01 ` Gilad Ben-Yossef
2020-05-02 5:31 ` [PATCH 07/20] crypto: hisilicon/sec2 " Eric Biggers
2020-05-02 5:31 ` [PATCH 08/20] crypto: mediatek " Eric Biggers
2020-05-02 5:31 ` [PATCH 09/20] crypto: n2 " Eric Biggers
2020-05-02 5:31 ` [PATCH 10/20] crypto: omap-sham " Eric Biggers
2020-05-02 5:31 ` [PATCH 11/20] crypto: s5p-sss " Eric Biggers
2020-05-05 14:19 ` Krzysztof Kozlowski
2020-05-02 5:31 ` [PATCH 12/20] nfc: s3fwrn5: " Eric Biggers
2020-05-02 5:31 ` [PATCH 13/20] fscrypt: " Eric Biggers
2020-05-02 5:31 ` [PATCH 14/20] ecryptfs: " Eric Biggers
2020-05-02 5:31 ` [PATCH 15/20] nfsd: " Eric Biggers
2020-05-04 19:09 ` J. Bruce Fields
2020-05-02 5:31 ` [PATCH 16/20] ubifs: " Eric Biggers
2020-05-02 5:31 ` [PATCH 17/20] Bluetooth: " Eric Biggers
2020-05-02 5:31 ` [PATCH 18/20] sctp: " Eric Biggers
2020-05-02 5:31 ` [PATCH 19/20] KEYS: encrypted: " Eric Biggers
2020-05-02 5:31 ` [PATCH 20/20] ASoC: cros_ec_codec: " Eric Biggers
2020-05-02 6:44 ` [PATCH 00/20] crypto: introduce crypto_shash_tfm_digest() Marcel Holtmann
2020-05-03 16:13 ` Ard Biesheuvel
2020-05-08 6:07 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2306b736-91df-3f76-0eb2-fe0308d144f2@amd.com \
--to=thomas.lendacky@amd.com \
--cc=ebiggers@kernel.org \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).