From: Zhou Wang <wangzhou1@hisilicon.com>
To: kbuild test robot <lkp@intel.com>
Cc: <kbuild-all@lists.01.org>, <linux-crypto@vger.kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
Shukun Tan <tanshukun1@huawei.com>
Subject: Re: [cryptodev:master 162/163] drivers/crypto/hisilicon/zip/zip_main.c:154:13: error: 'head' undeclared; did you mean '_end'?
Date: Fri, 1 Nov 2019 19:03:57 +0800 [thread overview]
Message-ID: <5DBC111D.7020101@hisilicon.com> (raw)
In-Reply-To: <201911011637.ZqPb4BBG%lkp@intel.com>
On 2019/11/1 16:33, kbuild test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
> head: 298b4c604008025b134bc6fccbc4018449945d60
> commit: 700f7d0d29c795c36517dcd3541e4432a76c2efc [162/163] crypto: hisilicon - fix to return sub-optimal device when best device has no qps
> config: alpha-allyesconfig (attached as .config)
> compiler: alpha-linux-gcc (GCC) 7.4.0
> reproduce:
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> git checkout 700f7d0d29c795c36517dcd3541e4432a76c2efc
> # save the attached .config to linux build tree
> GCC_VERSION=7.4.0 make.cross ARCH=alpha
>
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> drivers/crypto/hisilicon/zip/zip_main.c: In function 'find_zip_device':
>>> drivers/crypto/hisilicon/zip/zip_main.c:154:13: error: 'head' undeclared (first use in this function); did you mean '_end'?
> free_list(&head);
> ^~~~
> _end
> drivers/crypto/hisilicon/zip/zip_main.c:154:13: note: each undeclared identifier is reported only once for each function it appears in
> drivers/crypto/hisilicon/zip/zip_main.c:153:1: warning: label 'err' defined but not used [-Wunused-label]
> err:
> ^~~
will fix this by IS_ENABLED(CONFIG_NUMA).
>
> vim +154 drivers/crypto/hisilicon/zip/zip_main.c
>
> 104
> 105 struct hisi_zip *find_zip_device(int node)
> 106 {
> 107 struct hisi_zip *ret = NULL;
> 108 #ifdef CONFIG_NUMA
> 109 struct hisi_zip_resource *res, *tmp;
> 110 struct hisi_zip *hisi_zip;
> 111 struct list_head *n;
> 112 struct device *dev;
> 113 LIST_HEAD(head);
> 114
> 115 mutex_lock(&hisi_zip_list_lock);
> 116
> 117 list_for_each_entry(hisi_zip, &hisi_zip_list, list) {
> 118 res = kzalloc(sizeof(*res), GFP_KERNEL);
> 119 if (!res)
> 120 goto err;
> 121
> 122 dev = &hisi_zip->qm.pdev->dev;
> 123 res->hzip = hisi_zip;
> 124 res->distance = node_distance(dev->numa_node, node);
> 125
> 126 n = &head;
> 127 list_for_each_entry(tmp, &head, list) {
> 128 if (res->distance < tmp->distance) {
> 129 n = &tmp->list;
> 130 break;
> 131 }
> 132 }
> 133 list_add_tail(&res->list, n);
> 134 }
> 135
> 136 list_for_each_entry(tmp, &head, list) {
> 137 if (hisi_qm_get_free_qp_num(&tmp->hzip->qm)) {
> 138 ret = tmp->hzip;
> 139 break;
> 140 }
> 141 }
> 142
> 143 free_list(&head);
> 144 #else
> 145 mutex_lock(&hisi_zip_list_lock);
> 146
> 147 ret = list_first_entry(&hisi_zip_list, struct hisi_zip, list);
> 148 #endif
> 149 mutex_unlock(&hisi_zip_list_lock);
> 150
> 151 return ret;
> 152
> 153 err:
> > 154 free_list(&head);
> 155 mutex_unlock(&hisi_zip_list_lock);
> 156 return NULL;
> 157 }
> 158
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
>
prev parent reply other threads:[~2019-11-01 11:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 8:33 [cryptodev:master 162/163] drivers/crypto/hisilicon/zip/zip_main.c:154:13: error: 'head' undeclared; did you mean '_end'? kbuild test robot
2019-11-01 11:03 ` Zhou Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5DBC111D.7020101@hisilicon.com \
--to=wangzhou1@hisilicon.com \
--cc=herbert@gondor.apana.org.au \
--cc=kbuild-all@lists.01.org \
--cc=linux-crypto@vger.kernel.org \
--cc=lkp@intel.com \
--cc=tanshukun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).