From: Allen Pais <apais@linux.microsoft.com>
To: Giovanni Cabiddu <giovanni.cabiddu@intel.com>,
Allen Pais <allen.lkml@gmail.com>
Cc: herbert@gondor.apana.org.au, davem@davemloft.net,
nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com,
ludovic.desroches@microchip.com, jesper.nilsson@axis.com,
lars.persson@axis.com, horia.geanta@nxp.com,
aymen.sghaier@nxp.com, gcherian@marvell.com,
thomas.lendacky@amd.com, john.allen@amd.com, gilad@benyossef.com,
bbrezillon@kernel.org, arno@natisbad.org, schalla@marvell.com,
matthias.bgg@gmail.com, jamie@jamieiles.com, heiko@sntech.de,
krzk@kernel.org, vz@mleia.com, k.konieczny@samsung.com,
linux-crypto@vger.kernel.org, linux-mediatek@lists.infradead.org,
qat-linux@intel.com, linux-rockchip@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
Romain Perier <romain.perier@gmail.com>
Subject: Re: [PATCH v3 14/19] crypto: qat: convert tasklets to use new tasklet_setup() API
Date: Mon, 18 Jan 2021 12:41:36 +0530 [thread overview]
Message-ID: <94926b18-2e1e-0b85-41b2-a7e894d21998@linux.microsoft.com> (raw)
In-Reply-To: <20210114175109.GA8629@silpixa00400314>
>>
>> In preparation for unconditionally passing the
>> struct tasklet_struct pointer to all tasklet
>> callbacks, switch to using the new tasklet_setup()
>> and from_tasklet() to pass the tasklet pointer explicitly.
>
> I have two minor comments:
> * Patches to the qat driver have the following headline
> crypto: qat -
> * Checkpatch reports two alignment checks when it is run with --strict:
> CHECK: Alignment should match open parenthesis
> #33: FILE: drivers/crypto/qat/qat_common/adf_isr.c:248:
> + tasklet_setup(&priv_data->banks[i].resp_handler,
> + adf_response_handler);
>
> CHECK: Alignment should match open parenthesis
> #62: FILE: drivers/crypto/qat/qat_common/adf_sriov.c:57:
> + tasklet_setup(&vf_info->vf2pf_bh_tasklet,
> + adf_vf2pf_bh_handler);
>
> total: 0 errors, 0 warnings, 2 checks, 83 lines checked
>
> If you prefer I can resubmit this patch with these two changes.
Thank you. I will fix them and re-submit.
next prev parent reply other threads:[~2021-01-18 7:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 1:46 [PATCH v3 00/19]crypto: convert tasklets to use new tasklet_setup API() Allen Pais
2021-01-12 1:46 ` [PATCH v3 01/19] crypto: amcc: convert tasklets to use new tasklet_setup() API Allen Pais
2021-01-12 1:46 ` [PATCH v3 02/19] crypto: atmel: " Allen Pais
2021-01-12 1:46 ` [PATCH v3 03/19] crypto: axis: " Allen Pais
2021-01-12 1:46 ` [PATCH v3 04/19] crypto: caam: " Allen Pais
2021-01-12 1:46 ` [PATCH v3 05/19] crypto: cavium: " Allen Pais
2021-01-12 1:46 ` [PATCH v3 06/19] crypto: ccp: " Allen Pais
2021-01-13 16:17 ` John Allen
2021-01-12 1:46 ` [PATCH v3 07/19] crypto: ccree: " Allen Pais
2021-01-12 1:46 ` [PATCH v3 08/19] crypto: hifn_795x: " Allen Pais
2021-01-12 1:46 ` [PATCH v3 09/19] crypto: img-hash: " Allen Pais
2021-01-12 1:46 ` [PATCH v3 10/19] crypto: ixp4xx: " Allen Pais
2021-01-12 1:46 ` [PATCH v3 11/19] crypto: mediatek: " Allen Pais
2021-01-12 1:46 ` [PATCH v3 12/19] crypto: omap: " Allen Pais
2021-01-12 1:46 ` [PATCH v3 13/19] crypto: picoxcell: " Allen Pais
2021-01-12 1:46 ` [PATCH v3 14/19] crypto: qat: " Allen Pais
2021-01-14 17:51 ` Giovanni Cabiddu
2021-01-18 7:11 ` Allen Pais [this message]
2021-01-12 1:46 ` [PATCH v3 15/19] crypto: qce: " Allen Pais
2021-01-12 1:46 ` [PATCH v3 16/19] crypto: rockchip: " Allen Pais
2021-01-12 1:46 ` [PATCH v3 17/19] crypto: s5p: " Allen Pais
2021-01-12 1:46 ` [PATCH v3 18/19] crypto: talitos: " Allen Pais
2021-01-12 1:46 ` [PATCH v3 19/19] crypto: octeontx: " Allen Pais
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94926b18-2e1e-0b85-41b2-a7e894d21998@linux.microsoft.com \
--to=apais@linux.microsoft.com \
--cc=alexandre.belloni@bootlin.com \
--cc=allen.lkml@gmail.com \
--cc=arno@natisbad.org \
--cc=aymen.sghaier@nxp.com \
--cc=bbrezillon@kernel.org \
--cc=davem@davemloft.net \
--cc=gcherian@marvell.com \
--cc=gilad@benyossef.com \
--cc=giovanni.cabiddu@intel.com \
--cc=heiko@sntech.de \
--cc=herbert@gondor.apana.org.au \
--cc=horia.geanta@nxp.com \
--cc=jamie@jamieiles.com \
--cc=jesper.nilsson@axis.com \
--cc=john.allen@amd.com \
--cc=k.konieczny@samsung.com \
--cc=krzk@kernel.org \
--cc=lars.persson@axis.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=matthias.bgg@gmail.com \
--cc=nicolas.ferre@microchip.com \
--cc=qat-linux@intel.com \
--cc=romain.perier@gmail.com \
--cc=schalla@marvell.com \
--cc=thomas.lendacky@amd.com \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).