From: Horia Geanta <horia.geanta@nxp.com>
To: Vakul Garg <vakul.garg@nxp.com>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Cc: Aymen Sghaier <aymen.sghaier@nxp.com>,
"herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>
Subject: Re: [PATCH v2] crypto: caam/qi2 - Add printing dpseci fq stats using debugfs
Date: Mon, 22 Jul 2019 14:25:05 +0000 [thread overview]
Message-ID: <AM0PR0402MB3476F392D3A791DDE2F5B67898C40@AM0PR0402MB3476.eurprd04.prod.outlook.com> (raw)
In-Reply-To: 20190719111821.21696-1-vakul.garg@nxp.com
On 7/19/2019 2:23 PM, Vakul Garg wrote:
[...]
> +if CRYPTO_DEV_FSL_DPAA2_CAAM
> +
> +config CRYPTO_DEV_FSL_DPAA2_CAAM_DEBUGFS
> + depends on DEBUG_FS
> + bool "Enable debugfs support"
> + help
> + Selecting this will enable printing of various debug information
> + in the DPAA2 CAAM driver.
> +
> +endif
Let's enable this based on CONFIG_DEBUG_FS.
> diff --git a/drivers/crypto/caam/Makefile b/drivers/crypto/caam/Makefile
> index 9ab4e81ea21e..e4e9fa481a44 100644
> --- a/drivers/crypto/caam/Makefile
> +++ b/drivers/crypto/caam/Makefile
> @@ -30,3 +30,4 @@ endif
> obj-$(CONFIG_CRYPTO_DEV_FSL_DPAA2_CAAM) += dpaa2_caam.o
>
> dpaa2_caam-y := caamalg_qi2.o dpseci.o
> +dpaa2_caam-$(CONFIG_CRYPTO_DEV_FSL_DPAA2_CAAM_DEBUGFS) += dpseci-debugfs.o
dpaa2_caam-$(CONFIG_DEBUG_FS)
[...]
> diff --git a/drivers/crypto/caam/caamalg_qi2.h b/drivers/crypto/caam/caamalg_qi2.h
> index 973f6296bc6f..b450e2a25c1f 100644
> --- a/drivers/crypto/caam/caamalg_qi2.h
> +++ b/drivers/crypto/caam/caamalg_qi2.h
> @@ -10,6 +10,7 @@
> #include <soc/fsl/dpaa2-io.h>
> #include <soc/fsl/dpaa2-fd.h>
> #include <linux/threads.h>
> +#include <linux/netdevice.h>
How is this change related to current patch?
> #include "dpseci.h"
> #include "desc_constr.h"
>
> @@ -64,6 +65,7 @@ struct dpaa2_caam_priv {
> struct iommu_domain *domain;
>
> struct dpaa2_caam_priv_per_cpu __percpu *ppriv;
> + struct dentry *dfs_root;
dfs_root is used only in dpseci-debugfs.c, let's have it there as global.
Horia
next prev parent reply other threads:[~2019-07-22 14:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 11:23 [PATCH v2] crypto: caam/qi2 - Add printing dpseci fq stats using debugfs Vakul Garg
2019-07-22 14:25 ` Horia Geanta [this message]
2019-07-22 14:29 ` Vakul Garg
2019-07-22 15:20 ` Horia Geanta
2019-07-23 1:20 ` Vakul Garg
2019-07-23 6:14 ` Horia Geanta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR0402MB3476F392D3A791DDE2F5B67898C40@AM0PR0402MB3476.eurprd04.prod.outlook.com \
--to=horia.geanta@nxp.com \
--cc=aymen.sghaier@nxp.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=vakul.garg@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).