From: Linus Walleij <linus.walleij@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: linux-crypto@vger.kernel.org,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
Tudor Ambarus <tudor.ambarus@microchip.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [PATCH v2 2/6] crypto: atmel-ecc: add support for ACPI probing on non-AT91 platforms
Date: Fri, 24 May 2019 23:52:04 +0200 [thread overview]
Message-ID: <CACRpkdZsd+f6ajGKu71y13D7_6aEM_x6d4bJ0dLtGv7GmUYujg@mail.gmail.com> (raw)
In-Reply-To: <20190524162651.28189-3-ard.biesheuvel@linaro.org>
On Fri, May 24, 2019 at 6:27 PM Ard Biesheuvel
<ard.biesheuvel@linaro.org> wrote:
> The Atmel/Microchip EC508A is a I2C device that could be wired into
> any platform, and is being used on the Linaro/96boards Secure96
> mezzanine adapter. This means it could be found on any platform, even
> on ones that use ACPI enumeration (via PRP0001 devices). So update the
> code to enable this use case.
>
> This involves tweaking the bus rate discovery code to take ACPI probing
> into account, which records the maximum bus rate as a property of the
> slave device. For the atmel-ecc code, this means that the effective bus
> rate should never exceed the maximum rate, unless we are dealing with
> buggy firmware. Nonetheless, let's just use the existing plumbing to
> discover the bus rate and keep the existing logic intact.
>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Looks good to me.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
next prev parent reply other threads:[~2019-05-24 21:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-24 16:26 [PATCH v2 0/6] crypto - wire up Atmel SHA204A as RNG in DT and ACPI mode Ard Biesheuvel
2019-05-24 16:26 ` [PATCH v2 1/6] i2c: acpi: permit bus speed to be discovered after enumeration Ard Biesheuvel
2019-05-24 16:26 ` [PATCH v2 2/6] crypto: atmel-ecc: add support for ACPI probing on non-AT91 platforms Ard Biesheuvel
2019-05-24 21:52 ` Linus Walleij [this message]
2019-05-24 16:26 ` [PATCH v2 3/6] crypto: atmel-ecc: factor out code that can be shared Ard Biesheuvel
2019-05-24 16:26 ` [PATCH v2 4/6] crypto: atmel-i2c: add support for SHA204A random number generator Ard Biesheuvel
2019-05-24 16:26 ` [PATCH v2 5/6] dt-bindings: add Atmel SHA204A I2C crypto processor Ard Biesheuvel
2019-05-24 19:42 ` Rob Herring
2019-05-24 16:26 ` [PATCH v2 6/6] dt-bindings: move Atmel ECC508A I2C crypto processor to trivial-devices Ard Biesheuvel
2019-05-24 19:43 ` Rob Herring
2019-05-30 13:44 ` [PATCH v2 0/6] crypto - wire up Atmel SHA204A as RNG in DT and ACPI mode Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdZsd+f6ajGKu71y13D7_6aEM_x6d4bJ0dLtGv7GmUYujg@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=ard.biesheuvel@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=tudor.ambarus@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).