From: Mauricio Faria de Oliveira <mfo@canonical.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>, linux-crypto@vger.kernel.org
Subject: Re: [v2 PATCH] crypto: af_alg - fix use-after-free in af_alg_accept() due to bh_lock_sock()
Date: Wed, 10 Jun 2020 11:28:24 -0300 [thread overview]
Message-ID: <CAO9xwp2VryJi46+3UPhbQz3npCaZBziOTWEp+Kiqd90rMhkJXQ@mail.gmail.com> (raw)
In-Reply-To: <20200610002123.GA6230@gondor.apana.org.au>
On Tue, Jun 9, 2020 at 9:21 PM Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> On Tue, Jun 09, 2020 at 12:17:32PM -0300, Mauricio Faria de Oliveira wrote:
> >
> > Per your knowledge/experience with the crypto subsystem, the changed code
> > paths are not hot enough to suffer from such implications?
>
> I don't think replacing a spin-lock with a pair of atomic ops is
> going to be too much of an issue. We can always look at this again
> if someone comes up with real numbers of course.
Right; I meant the other places as well, where atomic ops were added
(in addition to the existing spinlocks.)
But indeed, real numbers would be great and tell whether or not
there's performance differences.
We're working on that -- Brian (bug reporter) has access to detailed
metrics/stats from the workload, and kindly agreed to set up two
identical instances to compare the numbers. I'll keep you posted.
Thank you,
Mauricio
>
> Cheers,
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
Mauricio Faria de Oliveira
next prev parent reply other threads:[~2020-06-10 14:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 16:16 [PATCH] crypto: af_alg - fix use-after-free in af_alg_accept() due to bh_lock_sock() Mauricio Faria de Oliveira
2020-06-08 6:48 ` [v2 PATCH] " Herbert Xu
2020-06-09 15:17 ` Mauricio Faria de Oliveira
2020-06-10 0:21 ` Herbert Xu
2020-06-10 14:28 ` Mauricio Faria de Oliveira [this message]
2020-06-12 18:32 ` Mauricio Faria de Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAO9xwp2VryJi46+3UPhbQz3npCaZBziOTWEp+Kiqd90rMhkJXQ@mail.gmail.com \
--to=mfo@canonical.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).