From: "Trahe, Fiona" <fiona.trahe@intel.com>
To: "Cabiddu, Giovanni" <giovanni.cabiddu@intel.com>,
"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>
Cc: "cohuck@redhat.com" <cohuck@redhat.com>,
"nhorman@redhat.com" <nhorman@redhat.com>,
"vdronov@redhat.com" <vdronov@redhat.com>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"Chambers, Mark A" <mark.a.chambers@intel.com>,
"McFadden, Gordon" <gordon.mcfadden@intel.com>,
"Atta, Ahsan" <ahsan.atta@intel.com>,
qat-linux <qat-linux@intel.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v4 0/5] vfio/pci: add denylist and disable qat
Date: Fri, 24 Jul 2020 10:39:59 +0000 [thread overview]
Message-ID: <SN6PR11MB288054DCE37102306FB38E9EE4770@SN6PR11MB2880.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200724084800.6136-1-giovanni.cabiddu@intel.com>
> -----Original Message-----
> From: Cabiddu, Giovanni <giovanni.cabiddu@intel.com>
> Sent: Friday, July 24, 2020 9:48 AM
> To: alex.williamson@redhat.com; herbert@gondor.apana.org.au
> Cc: cohuck@redhat.com; nhorman@redhat.com; vdronov@redhat.com; bhelgaas@google.com;
> Chambers, Mark A <mark.a.chambers@intel.com>; McFadden, Gordon <gordon.mcfadden@intel.com>;
> Atta, Ahsan <ahsan.atta@intel.com>; Trahe, Fiona <fiona.trahe@intel.com>; qat-linux <qat-
> linux@intel.com>; kvm@vger.kernel.org; linux-crypto@vger.kernel.org; linux-pci@vger.kernel.org; linux-
> kernel@vger.kernel.org; Cabiddu, Giovanni <giovanni.cabiddu@intel.com>
> Subject: [PATCH v4 0/5] vfio/pci: add denylist and disable qat
>
> This patchset defines a denylist of devices in the vfio-pci module and adds
> the current generation of Intel(R) QuickAssist devices to it as they are
> not designed to run in an untrusted environment.
>
> By default, if a device is in the denylist, the probe of vfio-pci fails.
> If a user wants to use a device in the denylist, he needs to disable the
> full denylist providing the option disable_denylist=1 at the load of
> vfio-pci or specifying that parameter in a config file in /etc/modprobe.d.
>
> This series also moves the device ids definitions present in the qat driver
> to linux/pci_ids.h since they will be shared between the vfio-pci and the qat
> drivers and replaces the custom ADF_SYSTEM_DEVICE macro with PCI_VDEVICE.
>
> The series is applicable to Herbert's tree. Patches 1 to 3 apply also to
> Alex's tree (next). Patches 4 and 5 are optional and can be applied at a later
> stage.
>
> Changes from v3:
> - Patch #1: included Acked-by tag, after ack from Bjorn Helgaas
> - Patch #2: s/prevents/allows/ in module parameter description
>
> Changes from v2:
> - Renamed blocklist in denylist
> - Patch #2: reworded module parameter description to clarify why a device is
> in the denylist
> - Patch #2: reworded warning that occurs when denylist is enabled and device
> is present in that list
>
> Changes from v1:
> - Reworked commit messages:
> Patches #1, #2 and #3: capitalized first character after column to comply to
> subject line convention
> Patch #3: Capitalized QAT acronym and added link and doc number for document
> "Intel® QuickAssist Technology (Intel® QAT) Software for Linux"
>
> Giovanni Cabiddu (5):
> PCI: Add Intel QuickAssist device IDs
> vfio/pci: Add device denylist
> vfio/pci: Add QAT devices to denylist
> crypto: qat - replace device ids defines
> crypto: qat - use PCI_VDEVICE
>
> drivers/crypto/qat/qat_c3xxx/adf_drv.c | 11 ++---
> drivers/crypto/qat/qat_c3xxxvf/adf_drv.c | 11 ++---
> drivers/crypto/qat/qat_c62x/adf_drv.c | 11 ++---
> drivers/crypto/qat/qat_c62xvf/adf_drv.c | 11 ++---
> .../crypto/qat/qat_common/adf_accel_devices.h | 6 ---
> drivers/crypto/qat/qat_common/qat_hal.c | 7 +--
> drivers/crypto/qat/qat_common/qat_uclo.c | 9 ++--
> drivers/crypto/qat/qat_dh895xcc/adf_drv.c | 11 ++---
> drivers/crypto/qat/qat_dh895xccvf/adf_drv.c | 11 ++---
> drivers/vfio/pci/vfio_pci.c | 48 +++++++++++++++++++
> include/linux/pci_ids.h | 6 +++
> 11 files changed, 87 insertions(+), 55 deletions(-)
>
> --
> 2.26.2
Reviewed-by: Fiona Trahe <fiona.trahe@intel.com>
prev parent reply other threads:[~2020-07-24 10:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 8:47 [PATCH v4 0/5] vfio/pci: add denylist and disable qat Giovanni Cabiddu
2020-07-24 8:47 ` [PATCH v4 1/5] PCI: Add Intel QuickAssist device IDs Giovanni Cabiddu
2020-07-24 8:47 ` [PATCH v4 2/5] vfio/pci: Add device denylist Giovanni Cabiddu
2020-07-24 9:28 ` Cornelia Huck
2020-07-24 8:47 ` [PATCH v4 3/5] vfio/pci: Add QAT devices to denylist Giovanni Cabiddu
2020-07-24 8:47 ` [PATCH v4 4/5] crypto: qat - replace device ids defines Giovanni Cabiddu
2020-07-24 8:48 ` [PATCH v4 5/5] crypto: qat - use PCI_VDEVICE Giovanni Cabiddu
2020-07-24 10:39 ` Trahe, Fiona [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR11MB288054DCE37102306FB38E9EE4770@SN6PR11MB2880.namprd11.prod.outlook.com \
--to=fiona.trahe@intel.com \
--cc=ahsan.atta@intel.com \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=cohuck@redhat.com \
--cc=giovanni.cabiddu@intel.com \
--cc=gordon.mcfadden@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=kvm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mark.a.chambers@intel.com \
--cc=nhorman@redhat.com \
--cc=qat-linux@intel.com \
--cc=vdronov@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).