From: Horia Geanta <horia.geanta@nxp.com>
To: Andrey Smirnov <andrew.smirnov@gmail.com>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Cc: Chris Spencer <christopher.spencer@sea.co.uk>,
Cory Tusar <cory.tusar@zii.aero>, Chris Healy <cphealy@gmail.com>,
Lucas Stach <l.stach@pengutronix.de>,
Aymen Sghaier <aymen.sghaier@nxp.com>,
Leonard Crestez <leonard.crestez@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 04/14] crypto: caam - request JR IRQ as the last step
Date: Tue, 23 Jul 2019 16:02:16 +0000 [thread overview]
Message-ID: <VI1PR0402MB34854421031A02B1AE3F953098C70@VI1PR0402MB3485.eurprd04.prod.outlook.com> (raw)
In-Reply-To: 20190717152458.22337-5-andrew.smirnov@gmail.com
On 7/17/2019 6:25 PM, Andrey Smirnov wrote:
> In order to avoid any risk of JR IRQ request being handled while some
> of the resources used for that are not yet allocated move the code
> requesting said IRQ to the endo of caam_jr_init(). No functional
^ typo
> change intended.
>
What qualifies as a "functional change"?
I've seen this comment in several commits.
> error = caam_reset_hw_jr(dev);
> if (error)
> - goto out_kill_deq;
> + return error;
>
> error = -ENOMEM;
> jrp->inpring = dmam_alloc_coherent(dev, sizeof(*jrp->inpring) *
> JOBR_DEPTH, &inpbusaddr,
> GFP_KERNEL);
> if (!jrp->inpring)
> - goto out_kill_deq;
> + return -ENOMEM;
Above there's "error = -ENOMEM;", so why not "return err;" here and
in all the other cases below?
>
> jrp->outring = dmam_alloc_coherent(dev, sizeof(*jrp->outring) *
> JOBR_DEPTH, &outbusaddr,
> GFP_KERNEL);
> if (!jrp->outring)
> - goto out_kill_deq;
> + return -ENOMEM;
>
> jrp->entinfo = devm_kcalloc(dev, JOBR_DEPTH, sizeof(*jrp->entinfo),
> GFP_KERNEL);
> if (!jrp->entinfo)
> - goto out_kill_deq;
> + return -ENOMEM;
>
> for (i = 0; i < JOBR_DEPTH; i++)
> jrp->entinfo[i].desc_addr_dma = !0;
> @@ -483,10 +472,19 @@ static int caam_jr_init(struct device *dev)
> (JOBR_INTC_COUNT_THLD << JRCFG_ICDCT_SHIFT) |
> (JOBR_INTC_TIME_THLD << JRCFG_ICTT_SHIFT));
>
> + tasklet_init(&jrp->irqtask, caam_jr_dequeue, (unsigned long)dev);
> +
> + /* Connect job ring interrupt handler. */
> + error = devm_request_irq(dev, jrp->irq, caam_jr_interrupt, IRQF_SHARED,
> + dev_name(dev), dev);
> + if (error) {
> + dev_err(dev, "can't connect JobR %d interrupt (%d)\n",
> + jrp->ridx, jrp->irq);
> + tasklet_kill(&jrp->irqtask);
> + return error;
"return error;" should be moved out the if block.
> + }
> +
> return 0;
> -out_kill_deq:
> - tasklet_kill(&jrp->irqtask);
> - return error;
> }
Horia
next prev parent reply other threads:[~2019-07-23 16:02 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 15:24 [PATCH v6 00/14] crypto: caam - Add i.MX8MQ support Andrey Smirnov
2019-07-17 15:24 ` [PATCH v6 01/14] crypto: caam - move DMA mask selection into a function Andrey Smirnov
2019-07-17 15:24 ` [PATCH v6 02/14] crypto: caam - simplfy clock initialization Andrey Smirnov
2019-07-23 14:17 ` Horia Geanta
2019-08-12 17:56 ` Andrey Smirnov
2019-07-17 15:24 ` [PATCH v6 03/14] crypto: caam - convert caam_jr_init() to use devres Andrey Smirnov
2019-07-23 15:48 ` Horia Geanta
2019-07-17 15:24 ` [PATCH v6 04/14] crypto: caam - request JR IRQ as the last step Andrey Smirnov
2019-07-23 16:02 ` Horia Geanta [this message]
2019-08-12 17:59 ` Andrey Smirnov
2019-07-17 15:24 ` [PATCH v6 05/14] crytpo: caam - make use of iowrite64*_hi_lo in wr_reg64 Andrey Smirnov
2019-07-29 15:29 ` Horia Geanta
2019-07-17 15:24 ` [PATCH v6 06/14] crypto: caam - use ioread64*_hi_lo in rd_reg64 Andrey Smirnov
2019-07-29 15:32 ` Horia Geanta
2019-07-17 15:24 ` [PATCH v6 07/14] crypto: caam - drop 64-bit only wr/rd_reg64() Andrey Smirnov
2019-07-29 15:32 ` Horia Geanta
2019-07-17 15:24 ` [PATCH v6 08/14] crypto: caam - make CAAM_PTR_SZ dynamic Andrey Smirnov
2019-07-23 9:57 ` Horia Geanta
2019-08-12 17:56 ` Andrey Smirnov
2019-07-17 15:24 ` [PATCH v6 09/14] crypto: caam - move cpu_to_caam_dma() selection to runtime Andrey Smirnov
2019-07-17 15:24 ` [PATCH v6 10/14] crypto: caam - drop explicit usage of struct jr_outentry Andrey Smirnov
2019-07-17 15:24 ` [PATCH v6 11/14] crypto: caam - don't hardcode inpentry size Andrey Smirnov
2019-07-17 15:24 ` [PATCH v6 12/14] crypto: caam - force DMA address to 32-bit on 64-bit i.MX SoCs Andrey Smirnov
2019-08-05 8:23 ` Horia Geanta
2019-08-12 19:27 ` Andrey Smirnov
2019-08-13 13:38 ` Horia Geanta
2019-08-13 18:50 ` Andrey Smirnov
2019-07-17 15:24 ` [PATCH v6 13/14] crypto: caam - always select job ring via RSR on i.MX8MQ Andrey Smirnov
2019-07-17 15:24 ` [PATCH v6 14/14] crypto: caam - add clock entry for i.MX8MQ Andrey Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0402MB34854421031A02B1AE3F953098C70@VI1PR0402MB3485.eurprd04.prod.outlook.com \
--to=horia.geanta@nxp.com \
--cc=andrew.smirnov@gmail.com \
--cc=aymen.sghaier@nxp.com \
--cc=christopher.spencer@sea.co.uk \
--cc=cory.tusar@zii.aero \
--cc=cphealy@gmail.com \
--cc=l.stach@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).