From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDF8DCA9EAF for ; Mon, 21 Oct 2019 16:35:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A41642084B for ; Mon, 21 Oct 2019 16:35:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=pensando.io header.i=@pensando.io header.b="ZvioHrwP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729514AbfJUQfK (ORCPT ); Mon, 21 Oct 2019 12:35:10 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:46593 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726289AbfJUQfH (ORCPT ); Mon, 21 Oct 2019 12:35:07 -0400 Received: by mail-pf1-f193.google.com with SMTP id q5so8737238pfg.13 for ; Mon, 21 Oct 2019 09:35:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=YQ2SYzDjclp6+UMcXfMKe/dCfkknHxuiGOrHRSVn0cA=; b=ZvioHrwPqgA32sqk/ZfXl+AIKFsddUO2tNAqbJtu4tCcRANhGvReU9J0qCrPtBX4dr XyEFxDF3rI4Skd8uu+tW37bMnIbIfeVll6YP9QPsiv1m3u9UI7Hz50C/EOmQGDDvJxjt MNnpf3ALOQX+wn100d4q49rWpqL/dLYkEvAbPydL+TGXqu4wUlet2YAblmsMtkne7qnv mFnrVk537e3SRZLOSIfp5DZTMcRh1T3I7huUyEOh7iplVBe4IuwO1byLK+LTz8AIzALW g8HnTvBYEWL7IAty6Tx+yooX0qDMEelsrde2cgdpkGApf9pCWxxWG6Loqrv6o3ZIrYoi o0cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=YQ2SYzDjclp6+UMcXfMKe/dCfkknHxuiGOrHRSVn0cA=; b=PtK6YwyNHsU+N6MORNxI3I9lTaFu9ZINIBbNI6l0Ro7oUjpPjkNB88+WAHP+gyAPXH gCTh7OgT6krhGDlU1PkPAZf0Fu+9VLQz+85AdgZYWq1nUM5BcftZbjAifZterSK/4e2r MiwLUo/S2cAxXDdMm0d3dB59ZoxZX510pc/DJ9SyuJfNjFvOFKQS2fA8p5aLDCXCfJa8 N7uMSezqx6e78iaCrS4GceUdYpyGIya4ZngbiLah819wLZpGHfguIcAGhOb1VEeSAzBI 3Ty3HVQV20XFIckyCxy9A+TZKeXOqWHawXFj6Coo9gSGA//GmCSyBgeGTM0yQFt1qoSA Zmvw== X-Gm-Message-State: APjAAAXZQZNO/SQkZ9JvWB3x8ss1m4Vh1jymZvug4VecQNrgL9uX8S2t nQlJO1KQdTAgrBszcVYvPh//hQ== X-Google-Smtp-Source: APXvYqwmyNu50+FxrTO6V6IulFup1S67xnT8cj+dbepaT4niD1qSPIKhFvBy+c/p26nJk53uezcFig== X-Received: by 2002:a63:ad0d:: with SMTP id g13mr26250877pgf.407.1571675706632; Mon, 21 Oct 2019 09:35:06 -0700 (PDT) Received: from Shannons-MacBook-Pro.local (static-50-53-47-17.bvtn.or.frontiernet.net. [50.53.47.17]) by smtp.gmail.com with ESMTPSA id e4sm16610297pff.22.2019.10.21.09.35.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Oct 2019 09:35:05 -0700 (PDT) Subject: Re: [PATCH 5/5] ionic: Use debugfs_create_bool() to export bool To: Geert Uytterhoeven , =?UTF-8?Q?Breno_Leit=c3=a3o?= , Nayna Jain , Paulo Flabiano Smorigo , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Herbert Xu , "David S . Miller" , Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= , David@rox.of.borg, David Airlie , Daniel Vetter , Casey Leedom , Pensando Drivers , Kevin Hilman , Nishanth Menon Cc: Greg Kroah-Hartman , linux-crypto@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, netdev@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20191021145149.31657-1-geert+renesas@glider.be> <20191021145149.31657-6-geert+renesas@glider.be> From: Shannon Nelson Message-ID: Date: Mon, 21 Oct 2019 09:35:03 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191021145149.31657-6-geert+renesas@glider.be> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On 10/21/19 7:51 AM, Geert Uytterhoeven wrote: > Currently bool ionic_cq.done_color is exported using > debugfs_create_u8(), which requires a cast, preventing further compiler > checks. > > Fix this by switching to debugfs_create_bool(), and dropping the cast. > > Signed-off-by: Geert Uytterhoeven Acked-by: Shannon Nelson > --- > drivers/net/ethernet/pensando/ionic/ionic_debugfs.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c b/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c > index bc03cecf80cc9eb4..5beba915f69d12dd 100644 > --- a/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c > +++ b/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c > @@ -170,8 +170,7 @@ void ionic_debugfs_add_qcq(struct ionic_lif *lif, struct ionic_qcq *qcq) > debugfs_create_x64("base_pa", 0400, cq_dentry, &cq->base_pa); > debugfs_create_u32("num_descs", 0400, cq_dentry, &cq->num_descs); > debugfs_create_u32("desc_size", 0400, cq_dentry, &cq->desc_size); > - debugfs_create_u8("done_color", 0400, cq_dentry, > - (u8 *)&cq->done_color); > + debugfs_create_bool("done_color", 0400, cq_dentry, &cq->done_color); > > debugfs_create_file("tail", 0400, cq_dentry, cq, &cq_tail_fops); >