linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tero Kristo <t-kristo@ti.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: <davem@davemloft.net>, <linux-crypto@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <j-keerthy@ti.com>
Subject: Re: [PATCHv4 3/7] crypto: sa2ul: add sha1/sha256/sha512 support
Date: Tue, 30 Jun 2020 10:20:06 +0300	[thread overview]
Message-ID: <b8c209cd-2b5d-54e4-9b64-94e5d1f0e60c@ti.com> (raw)
In-Reply-To: <20200630044936.GA22565@gondor.apana.org.au>

On 30/06/2020 07:49, Herbert Xu wrote:
> On Fri, Jun 26, 2020 at 12:15:42PM +0300, Tero Kristo wrote:
>>
>> I have been experimenting with an alternate approach, where I have a small
>> buffer within the context, this would be more like the way other drivers do
>> this. If the buffer is closed before running out of space, I can push this
>> to be processed by HW, otherwise I must fallback to SW. Does this sound like
>> a better approach?
> 
> You can buffer up to a block obviously.  Anything beyond that
> should just use a fallback.

Only up-to block size? This would limit the buffer to 64-128 bytes.

I was hoping I could cache data upto 1024 bytes at least in the context, 
as this would allow running certain openssl cases with hw accelerated 
crypto. Openssl speed test via cryptodev appears to do sha_init - 
sha_update - sha_final chain with any size data.

-Tero
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

  reply	other threads:[~2020-06-30  7:20 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-15  7:14 [PATCHv4 0/7] crypto: sa2ul support for TI K3 SoCs Tero Kristo
2020-06-15  7:14 ` [PATCHv4 1/7] dt-bindings: crypto: Add TI SA2UL crypto accelerator documentation Tero Kristo
2020-06-15  7:14 ` [PATCHv4 2/7] crypto: sa2ul: Add crypto driver Tero Kristo
2020-06-15  7:14 ` [PATCHv4 3/7] crypto: sa2ul: add sha1/sha256/sha512 support Tero Kristo
2020-06-26  4:31   ` Herbert Xu
2020-06-26  9:15     ` Tero Kristo
2020-06-30  4:49       ` Herbert Xu
2020-06-30  7:20         ` Tero Kristo [this message]
2020-06-30  7:46           ` Herbert Xu
2020-06-30  7:52             ` Tero Kristo
2020-06-30  7:54               ` Herbert Xu
2020-06-30  7:58                 ` Tero Kristo
2020-06-30  7:59                   ` Herbert Xu
2020-06-30  8:17                     ` Tero Kristo
2020-06-15  7:14 ` [PATCHv4 4/7] crypto: sa2ul: Add AEAD algorithm support Tero Kristo
2020-06-15  7:14 ` [PATCHv4 5/7] crypto: sa2ul: add device links to child devices Tero Kristo
2020-06-15  7:14 ` [PATCHv4 6/7] arm64: dts: ti: k3-am6: Add crypto accelarator node Tero Kristo
2020-06-15  7:14 ` [PATCHv4 7/7] arm64: dts: ti: k3-j721e-main: Add crypto accelerator node Tero Kristo
2020-06-15 18:20 ` [PATCHv4 0/7] crypto: sa2ul support for TI K3 SoCs Eric Biggers
2020-06-16  4:24   ` Tero Kristo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b8c209cd-2b5d-54e4-9b64-94e5d1f0e60c@ti.com \
    --to=t-kristo@ti.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=j-keerthy@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).