From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Thomas De Schampheleire <patrickdepinguin@gmail.com>
Cc: Mao Han <han_mao@c-sky.com>,
xianmiao_qu@c-sky.com, ren_guo@c-sky.com,
linux-csky@vger.kernel.org, hongdeng_chen@c-sky.com,
thomas.petazzoni@bootlin.com, buildroot <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH 1/2] package/toolchain-external: ensure ARCH_LIB_DIR exist
Date: Sun, 26 Jan 2020 16:34:43 +0100 [thread overview]
Message-ID: <20200126153443.GP32369@scaer> (raw)
In-Reply-To: <CAAXf6LV-f9o_9oY4+Me4qHRJeQhCWA75H1GOEYMoRPu5j4m-Jg@mail.gmail.com>
Mao, All,
On 2020-01-24 16:00 +0100, Thomas De Schampheleire spake thusly:
> El vie., 17 ene. 2020 a las 3:35, Mao Han (<han_mao@c-sky.com>) escribió:
[--SNIP--]
> > There is another patch in the same thread:
> > [PATCH 2/2] toolchain: Get ld.so name if available
> > http://buildroot-busybox.2317881.n4.nabble.com/PATCH-1-2-package-toolchain-external-ensure-ARCH-LIB-DIR-exist-td243604.html#a244193
> > Tried to get the corresponding ld.so name with certain configuration.
> Thanks. Using this patch '[PATCH 2/2] toolchain: Get ld.so name if
> available' I actually can compile correctly.
> So, PATCH 1/2 is not actually needed.
>
> Do you agree that only PATCH 2/2 is required?
> If so I will perform a more thorough review of that patch.
Given the feedback from Thomas, and the coments I provided on the second
patch, I've marked the two patches as Changes Requested on patchwork.
Thank you! :-)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2020-01-26 15:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-02 3:57 [PATCH 1/2] package/toolchain-external: ensure ARCH_LIB_DIR exist Mao Han
2020-01-02 3:57 ` [PATCH 2/2] toolchain: Get ld.so name if available Mao Han
2020-01-26 15:31 ` [Buildroot] " Yann E. MORIN
2020-02-05 10:30 ` Thomas De Schampheleire
2020-01-10 10:57 ` [Buildroot] [PATCH 1/2] package/toolchain-external: ensure ARCH_LIB_DIR exist Thomas De Schampheleire
2020-01-10 11:15 ` Thomas Petazzoni
2020-01-13 3:34 ` Mao Han
2020-01-16 9:36 ` Thomas De Schampheleire
2020-01-17 2:35 ` Mao Han
2020-01-24 15:00 ` Thomas De Schampheleire
2020-01-26 15:34 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200126153443.GP32369@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=han_mao@c-sky.com \
--cc=hongdeng_chen@c-sky.com \
--cc=linux-csky@vger.kernel.org \
--cc=patrickdepinguin@gmail.com \
--cc=ren_guo@c-sky.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=xianmiao_qu@c-sky.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).