From: Guenter Roeck <linux@roeck-us.net>
To: Guo Ren <guoren@linux.alibaba.com>
Cc: linux-csky@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] csky: Fixup calltrace panic
Date: Sun, 17 May 2020 10:52:20 -0700 [thread overview]
Message-ID: <20200517175220.GA48379@roeck-us.net> (raw)
Hi,
On Wed, May 13, 2020 at 03:15:25PM +0800, Guo Ren wrote:
> The implementation of show_stack will panic with wrong fp:
>
> addr = *fp++;
>
> because the fp isn't checked properly.
>
> The current implementations of show_stack, wchan and stack_trace
> haven't been designed properly, so just deprecate them.
>
> This patch is a reference to riscv's way, all codes are modified from
> arm's. The patch is passed with:
>
> - cat /proc/<pid>/stack
> - cat /proc/<pid>/wchan
> - echo c > /proc/sysrq-trigger
>
> Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
This patch results in:
gcc version: csky-linux-gcc (GCC) 9.3.0
Building csky:defconfig ... failed
--------------
Error log:
csky-linux-gcc: error: unrecognized command line option '-mbacktrace'; did you mean '-fbacktrace'?
csky-linux-gcc: error: unrecognized command line option '-mbacktrace'; did you mean '-fbacktrace'?
make[2]: *** [scripts/mod/devicetable-offsets.s] Error 1
make[2]: *** Waiting for unfinished jobs....
csky-linux-gcc: error: unrecognized command line option '-mbacktrace'; did you mean '-fbacktrace'?
make[2]: *** [scripts/mod/empty.o] Error 1
make[1]: *** [prepare0] Error 2
make: *** [sub-make] Error 2
when trying to build csky images with upstream gcc 9.3.0.
What version of gcc is needed to build csky images ? Also, would it be
possible to support the upstream version of gcc ?
Thanks,
Guenter
next reply other threads:[~2020-05-17 17:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-17 17:52 Guenter Roeck [this message]
2020-05-20 7:50 ` [PATCH] csky: Fixup calltrace panic Guo Ren
2020-05-21 14:46 ` Guenter Roeck
2020-05-22 15:28 ` Guo Ren
2020-05-22 21:28 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200517175220.GA48379@roeck-us.net \
--to=linux@roeck-us.net \
--cc=guoren@linux.alibaba.com \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).