From: Christoph Hellwig <hch@infradead.org>
To: guoren@kernel.org
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org,
linux-csky@vger.kernel.org, linux-arch@vger.kernel.org,
Guo Ren <guoren@linux.alibaba.com>
Subject: Re: [PATCH] csky: uaccess.h: Coding convention with asm generic
Date: Wed, 21 Apr 2021 15:48:04 +0100 [thread overview]
Message-ID: <20210421144804.GA3969416@infradead.org> (raw)
In-Reply-To: <1618995255-91499-1-git-send-email-guoren@kernel.org>
On Wed, Apr 21, 2021 at 08:54:15AM +0000, guoren@kernel.org wrote:
> From: Guo Ren <guoren@linux.alibaba.com>
>
> Using asm-generic/uaccess.h to prevent duplicated code:
> - Add user_addr_max which mentioned in generic uaccess.h
> - Remove custom definitions of KERNEL/USER_DS, get/set_fs,
> uaccess_kerenl
Instead of using the generic definitions removing support for set_fs
entirely would be much preferred. The series in linux-next for mips,
or the riscv version that landed in 5.10 might be good examples.
next prev parent reply other threads:[~2021-04-21 14:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 8:54 [PATCH] csky: uaccess.h: Coding convention with asm generic guoren
2021-04-21 14:48 ` Christoph Hellwig [this message]
2021-04-28 3:18 ` Guenter Roeck
2021-04-28 8:29 ` Guo Ren
2021-04-28 9:25 ` Arnd Bergmann
2021-04-28 12:49 ` Christoph Hellwig
2021-04-28 13:07 ` Guo Ren
2021-04-28 13:48 ` Arnd Bergmann
2021-04-28 13:03 ` Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210421144804.GA3969416@infradead.org \
--to=hch@infradead.org \
--cc=arnd@arndb.de \
--cc=guoren@kernel.org \
--cc=guoren@linux.alibaba.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).