From: Guo Ren <guoren@kernel.org>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>,
arnout@mind.be, linux-csky@vger.kernel.org,
buildroot@buildroot.org, Guo Ren <ren_guo@c-sky.com>
Subject: Re: [PATCH V3 01/10] arch/csky: Use VDSP instead of DSP
Date: Wed, 29 May 2019 15:30:45 +0800 [thread overview]
Message-ID: <CAJF2gTQC8UigBniC_RKUVFddX=PnN7O9GyBZXcxyXuPBg9WNHw@mail.gmail.com> (raw)
In-Reply-To: <20190529092128.36183371@windsurf.home>
OK, two pathes.
On Wed, May 29, 2019 at 3:21 PM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> Hello Guo,
>
> Thanks for this new iteration. I apologize, but unfortunately it's
> still not good, and doesn't match the suggestions I did.
>
> On Wed, 29 May 2019 15:18:39 +0800
> guoren@kernel.org wrote:
>
> > From: Guo Ren <ren_guo@c-sky.com>
> >
> > Use VDSP enhanced instructions Co-processor instead of DSP.
>
> Your commit log should explain why.
>
> > Signed-off-by: Guo Ren <ren_guo@c-sky.com>
> > ---
> > arch/Config.in.csky | 17 +++--------------
> > arch/arch.mk.csky | 24 ++++++++++++++++++++++++
>
> The change to using arch.mk.csky should be done separately. So this
> commit should be split into two:
>
> - One switching to using arch.mk.sky, without changing DSP -> VDSP
>
> - A follow-up one changing DSP -> VDSP, with a commit log that
> explains why you make this chang
>
> Thanks,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
next prev parent reply other threads:[~2019-05-29 7:31 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 7:18 [PATCH V3 00/10] Update arch/csky for buildroot guoren
2019-05-29 7:18 ` [PATCH V3 01/10] arch/csky: Use VDSP instead of DSP guoren
2019-05-29 7:21 ` Thomas Petazzoni
2019-05-29 7:30 ` Guo Ren [this message]
2019-05-29 7:56 ` Thomas Petazzoni
2019-05-29 8:12 ` Guo Ren
2019-05-29 8:38 ` Thomas Petazzoni
2019-05-29 9:02 ` Guo Ren
2019-05-29 9:06 ` Guo Ren
2019-05-29 9:23 ` Thomas Petazzoni
2019-05-29 9:45 ` Guo Ren
2019-05-29 11:58 ` Thomas Petazzoni
2019-05-29 12:34 ` Guo Ren
2019-05-29 7:18 ` [PATCH V3 02/10] arch/csky: Add ck860 supported guoren
2019-05-29 7:18 ` [PATCH V3 03/10] arch/csky: Add FLOAT_ABI compiler options guoren
2019-05-29 7:23 ` Thomas Petazzoni
2019-05-29 7:30 ` Guo Ren
2019-05-29 7:57 ` Thomas Petazzoni
2019-05-29 8:30 ` Guo Ren
2019-05-29 8:39 ` Thomas Petazzoni
2019-05-29 8:53 ` Guo Ren
2019-05-29 7:39 ` Guo Ren
2019-05-29 7:18 ` [PATCH V3 04/10] arch/csky: Add ABI variable for toolchain build guoren
2019-05-29 7:18 ` [PATCH V3 05/10] package/binutils: Add C-SKY support guoren
2019-05-29 7:18 ` [PATCH V3 06/10] package/gcc: " guoren
2019-05-29 7:18 ` [PATCH V3 07/10] package/gdb: " guoren
2019-05-29 7:18 ` [PATCH V3 08/10] package/glibc: " guoren
2019-05-29 7:18 ` [PATCH V3 09/10] configs/qemu_cskyXXX_virt: new defconfig guoren
2019-05-29 7:18 ` [PATCH V3 10/10] arch/csky: Enable csky toolchain build guoren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJF2gTQC8UigBniC_RKUVFddX=PnN7O9GyBZXcxyXuPBg9WNHw@mail.gmail.com' \
--to=guoren@kernel.org \
--cc=arnout@mind.be \
--cc=buildroot@buildroot.org \
--cc=linux-csky@vger.kernel.org \
--cc=ren_guo@c-sky.com \
--cc=thomas.de_schampheleire@nokia.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).