From: Pekka Enberg <penberg@gmail.com>
To: guoren@kernel.org
Cc: palmerdabbelt@google.com,
Paul Walmsley <paul.walmsley@sifive.com>,
Anup Patel <anup@brainfault.org>,
greentime.hu@sifive.com, zong.li@sifive.com, me@packi.ch,
bjorn.topel@gmail.com, atish.patra@wdc.com,
linux-riscv@lists.infradead.org,
Guo Ren <guoren@linux.alibaba.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-csky@vger.kernel.org
Subject: Re: [PATCH V1 0/5] riscv: Add k/uprobe supported
Date: Sat, 4 Jul 2020 09:39:50 +0300 [thread overview]
Message-ID: <CAOJsxLFF4o8AFWzPFJgwaeuA=Lb9VsjMXXfVmbhZBwLPcG=Asg@mail.gmail.com> (raw)
In-Reply-To: <1593833659-26224-1-git-send-email-guoren@kernel.org>
On Sat, Jul 4, 2020 at 6:34 AM <guoren@kernel.org> wrote:
> The patchset includes kprobe/uprobe support and some related fixups.
Nice!
On Sat, Jul 4, 2020 at 6:34 AM <guoren@kernel.org> wrote:
> There is no single step exception in riscv ISA, so utilize ebreak to
> simulate. Some pc related instructions couldn't be executed out of line
> and some system/fence instructions couldn't be a trace site at all.
> So we give out a reject list and simulate list in decode-insn.c.
Can you elaborate on what you mean by this? Why would you need a
single-step facility for kprobes? Is it for executing the instruction
that was replaced with a probe breakpoint?
Also, the "Debug Specification" [1] specifies a single-step facility
for RISC-V -- why is that not useful for implementing kprobes?
1. https://riscv.org/specifications/debug-specification/
- Pekka
next prev parent reply other threads:[~2020-07-04 6:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-04 3:34 [PATCH V1 0/5] riscv: Add k/uprobe supported guoren
2020-07-04 3:34 ` [PATCH V1 1/5] riscv: Fixup __vdso_gettimeofday broke dynamic ftrace guoren
2020-07-04 3:34 ` [PATCH V1 2/5] RISC-V: Implement ptrace regs and stack API guoren
2020-07-07 8:21 ` Zong Li
2020-07-04 3:34 ` [PATCH V1 3/5] riscv: Fixup compile error BUILD_BUG_ON failed guoren
2020-07-04 3:34 ` [PATCH V1 4/5] riscv: Add kprobes supported guoren
2020-07-06 10:11 ` Masami Hiramatsu
2020-07-07 8:25 ` Zong Li
2020-07-07 8:53 ` Guo Ren
2020-07-04 3:34 ` [PATCH V1 5/5] riscv: Add uprobes supported guoren
2020-07-04 6:39 ` Pekka Enberg [this message]
2020-07-04 14:55 ` [PATCH V1 0/5] riscv: Add k/uprobe supported Guo Ren
2020-07-04 18:30 ` Pekka Enberg
2020-07-14 18:43 ` Palmer Dabbelt
2020-07-15 5:01 ` Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOJsxLFF4o8AFWzPFJgwaeuA=Lb9VsjMXXfVmbhZBwLPcG=Asg@mail.gmail.com' \
--to=penberg@gmail.com \
--cc=anup@brainfault.org \
--cc=atish.patra@wdc.com \
--cc=bjorn.topel@gmail.com \
--cc=greentime.hu@sifive.com \
--cc=guoren@kernel.org \
--cc=guoren@linux.alibaba.com \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=me@packi.ch \
--cc=palmerdabbelt@google.com \
--cc=paul.walmsley@sifive.com \
--cc=zong.li@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).