From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: guoren@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org,
Guo Ren <guoren@linux.alibaba.com>,
Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <maz@kernel.org>
Subject: Re: [PATCH v2 2/2] drivers/clocksource: Fixup csky,mptimer compile error with CPU_CK610
Date: Thu, 4 Feb 2021 09:48:20 +0100 [thread overview]
Message-ID: <c36b816b-6d80-9542-45fc-507c5cc302fb@linaro.org> (raw)
In-Reply-To: <20210204074609.3553018-2-guoren@kernel.org>
On 04/02/2021 08:46, guoren@kernel.org wrote:
> From: Guo Ren <guoren@linux.alibaba.com>
>
> The timer-mp-csky.c only could support CPU_CK860 and it will
> compile error with CPU_CK610.
>
> It has been selected in arch/csky/Kconfig.
It would be better if you fix the root cause of the compilation error.
The COMPILE_TEST is there for compilation test coverage when the changes
are touching a lot of drivers.
> Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Marc Zyngier <maz@kernel.org>
> ---
> drivers/clocksource/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> ---
> v2: Drop the string after bool,
> as suggested by Marc Zyngier <maz@kernel.org>
>
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index 14c7c4712478..d39e6ca86d25 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -662,7 +662,7 @@ config CLINT_TIMER
> driver is usually used for NoMMU RISC-V systems.
>
> config CSKY_MP_TIMER
> - bool "SMP Timer for the C-SKY platform" if COMPILE_TEST
> + bool
> depends on CSKY
> select TIMER_OF
> help
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2021-02-04 8:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 7:46 [PATCH v2 1/2] drivers/irqchip: Fixup csky,mpintc compile error with CPU_CK610 guoren
2021-02-04 7:46 ` [PATCH v2 2/2] drivers/clocksource: Fixup csky,mptimer " guoren
2021-02-04 8:48 ` Daniel Lezcano [this message]
2021-02-07 3:31 ` Guo Ren
2021-02-07 3:34 ` Guo Ren
2021-02-07 9:29 ` Daniel Lezcano
2021-02-09 16:02 ` Guo Ren
2021-02-09 20:26 ` Daniel Lezcano
2021-02-10 3:03 ` Guo Ren
2021-02-04 15:55 ` (subset) [PATCH v2 1/2] drivers/irqchip: Fixup csky,mpintc " Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c36b816b-6d80-9542-45fc-507c5cc302fb@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=guoren@kernel.org \
--cc=guoren@linux.alibaba.com \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).