From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D41151BDCD for ; Wed, 6 Mar 2024 06:47:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709707627; cv=none; b=FLbF2d5UG9g8f/btYX92huJNFG8yxUdFGwR28aa9kxdvRcK7oFg8CtU7V9AS3a3ibQPf3tyAn5wLxV+TgtnjUppInYp43vBlvlXUf3dOuOPwOT3WOAoIRDtJFr9tv+l+JCkPTUJFVoIm8IxigPqO0oVtC4W94+sN/xElV8n5uPU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709707627; c=relaxed/simple; bh=vX8XUXxxK22yIALT2R8BH9LybpjMPZXROgwcyxpAR+w=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=N3LpDin6TA7IstqtEkogU1+5dSi5XinQZXe9ACCHwUGrmPcBBIaUDrQtNOuvFA3vwfsL6dC0KQnajjrNqRX2tgszc/ztbDgkwrLU/dOOs30n3sZapbkgL0VV0MKtXOJWDnIihA3S6JSckzkyZv4OWhHRGiUesFtxDyvvLMgxS8k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=j5dN/Sa3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="j5dN/Sa3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 67AAEC433F1; Wed, 6 Mar 2024 06:47:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1709707627; bh=vX8XUXxxK22yIALT2R8BH9LybpjMPZXROgwcyxpAR+w=; h=From:To:Cc:Subject:Date:Reply-to:From; b=j5dN/Sa30t4LeFySaOynrT33xF7Pkk3dkh8OdEhfVTllX4Z8nMNMIjMTcuutQpAJY S197qfr17nW8Mqb2ImnYFphIGcIH2gMmGdzMPgeNNzGECokBG0MHVsuIYP2YOetlTu oCaKC9cp0hQPnkJoIpX5dQYVGlfbJzWoVH3GcRWo= From: Greg Kroah-Hartman To: linux-cve-announce@vger.kernel.org Cc: Greg Kroah-Hartman Subject: CVE-2024-26627: scsi: core: Move scsi_host_busy() out of host lock for waking up EH handler Date: Wed, 6 Mar 2024 06:46:10 +0000 Message-ID: <2024030648-CVE-2024-26627-e3a2@gregkh> X-Mailer: git-send-email 2.44.0 Precedence: bulk X-Mailing-List: linux-cve-announce@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Reply-to: , X-Developer-Signature: v=1; a=openpgp-sha256; l=3423; i=gregkh@linuxfoundation.org; h=from:subject:message-id; bh=vX8XUXxxK22yIALT2R8BH9LybpjMPZXROgwcyxpAR+w=; b=owGbwMvMwCRo6H6F97bub03G02pJDKkvBGUmb2oQ7sgtNlHTupDznUvIp+dbutDWjY8dbjmYu J9Xkd3fEcvCIMjEICumyPJlG8/R/RWHFL0MbU/DzGFlAhnCwMUpABPJrmCYX7Goh3Pf/F0xLlKc qVbPsyy8tj75xzCHd2rCbq7UNSl7P705sFg9vaH/UpMLAA== X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 Content-Transfer-Encoding: 8bit Description =========== In the Linux kernel, the following vulnerability has been resolved: scsi: core: Move scsi_host_busy() out of host lock for waking up EH handler Inside scsi_eh_wakeup(), scsi_host_busy() is called & checked with host lock every time for deciding if error handler kthread needs to be waken up. This can be too heavy in case of recovery, such as: - N hardware queues - queue depth is M for each hardware queue - each scsi_host_busy() iterates over (N * M) tag/requests If recovery is triggered in case that all requests are in-flight, each scsi_eh_wakeup() is strictly serialized, when scsi_eh_wakeup() is called for the last in-flight request, scsi_host_busy() has been run for (N * M - 1) times, and request has been iterated for (N*M - 1) * (N * M) times. If both N and M are big enough, hard lockup can be triggered on acquiring host lock, and it is observed on mpi3mr(128 hw queues, queue depth 8169). Fix the issue by calling scsi_host_busy() outside the host lock. We don't need the host lock for getting busy count because host the lock never covers that. [mkp: Drop unnecessary 'busy' variables pointed out by Bart] The Linux kernel CVE team has assigned CVE-2024-26627 to this issue. Affected and fixed versions =========================== Issue introduced in 5.5 with commit 6eb045e092ef and fixed in 5.10.210 with commit f5944853f7a9 Issue introduced in 5.5 with commit 6eb045e092ef and fixed in 5.15.149 with commit d37c1c81419f Issue introduced in 5.5 with commit 6eb045e092ef and fixed in 6.1.77 with commit db6338f45971 Issue introduced in 5.5 with commit 6eb045e092ef and fixed in 6.6.16 with commit 65ead8468c21 Issue introduced in 5.5 with commit 6eb045e092ef and fixed in 6.7.4 with commit 07e3ca0f17f5 Issue introduced in 5.5 with commit 6eb045e092ef and fixed in 6.8-rc3 with commit 4373534a9850 Please see https://www.kernel.org or a full list of currently supported kernel versions by the kernel community. Unaffected versions might change over time as fixes are backported to older supported kernel versions. The official CVE entry at https://cve.org/CVERecord/?id=CVE-2024-26627 will be updated if fixes are backported, please check that for the most up to date information about this issue. Affected files ============== The file(s) affected by this issue are: drivers/scsi/scsi_error.c drivers/scsi/scsi_lib.c drivers/scsi/scsi_priv.h Mitigation ========== The Linux kernel CVE team recommends that you update to the latest stable kernel version for this, and many other bugfixes. Individual changes are never tested alone, but rather are part of a larger kernel release. Cherry-picking individual commits is not recommended or supported by the Linux kernel community at all. If however, updating to the latest release is impossible, the individual changes to resolve this issue can be found at these commits: https://git.kernel.org/stable/c/f5944853f7a961fedc1227dc8f60393f8936d37c https://git.kernel.org/stable/c/d37c1c81419fdef66ebd0747cf76fb8b7d979059 https://git.kernel.org/stable/c/db6338f45971b4285ea368432a84033690eaf53c https://git.kernel.org/stable/c/65ead8468c21c2676d4d06f50b46beffdea69df1 https://git.kernel.org/stable/c/07e3ca0f17f579491b5f54e9ed05173d6c1d6fcb https://git.kernel.org/stable/c/4373534a9850627a2695317944898eb1283a2db0