From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8948C4727C for ; Thu, 1 Oct 2020 07:22:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AC14B21531 for ; Thu, 1 Oct 2020 07:22:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731106AbgJAHWL (ORCPT ); Thu, 1 Oct 2020 03:22:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725938AbgJAHWK (ORCPT ); Thu, 1 Oct 2020 03:22:10 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73C89C0613D0 for ; Thu, 1 Oct 2020 00:22:10 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1kNsuk-0000iy-E1; Thu, 01 Oct 2020 09:22:06 +0200 Subject: Re: [PATCH v2 08/12] ARM: dts: imx6dl-pico: fix board compatibles To: Krzysztof Kozlowski , Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Anson Huang , Andreas Kemnade , Stefan Riedmueller , Robert Jones , Li Yang , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20200930190143.27032-1-krzk@kernel.org> <20200930190143.27032-9-krzk@kernel.org> From: Ahmad Fatoum Message-ID: <0a0afea6-8cbb-3e89-5a4f-89660c942ca3@pengutronix.de> Date: Thu, 1 Oct 2020 09:22:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200930190143.27032-9-krzk@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hello Krzysztof, On 9/30/20 9:01 PM, Krzysztof Kozlowski wrote: > There are four flavors of TechNexion PICO-IMX6 boards. They have their > own DTSes, even though in Dwarf, Nymph and Pi are exactly the same. > They also have their own bindings so adjust the compatibles to match the > bindings. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes since v1: > 1. None > --- > arch/arm/boot/dts/imx6dl-pico-dwarf.dts | 2 +- > arch/arm/boot/dts/imx6dl-pico-hobbit.dts | 2 +- > arch/arm/boot/dts/imx6dl-pico-nymph.dts | 2 +- > arch/arm/boot/dts/imx6dl-pico-pi.dts | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/imx6dl-pico-dwarf.dts b/arch/arm/boot/dts/imx6dl-pico-dwarf.dts > index 659a8e8714ea..d85b15a8c127 100644 > --- a/arch/arm/boot/dts/imx6dl-pico-dwarf.dts > +++ b/arch/arm/boot/dts/imx6dl-pico-dwarf.dts > @@ -13,5 +13,5 @@ > > / { > model = "TechNexion PICO-IMX6 DualLite/Solo Board and Dwarf baseboard"; > - compatible = "technexion,imx6dl-pico", "fsl,imx6dl"; > + compatible = "technexion,imx6dl-pico-dwarf", "fsl,imx6dl"; Could you change this to have all three compatibles ("technexion,imx6dl-pico-dwarf", "technexion,imx6dl-pico", "fsl,imx6dl") and likewise for the other files? That way other firmware that reuses the Linux device tree files and match against the SoM compatible continues to work after update. > }; > diff --git a/arch/arm/boot/dts/imx6dl-pico-hobbit.dts b/arch/arm/boot/dts/imx6dl-pico-hobbit.dts > index d7403c5c4337..08fedcbcc91b 100644 > --- a/arch/arm/boot/dts/imx6dl-pico-hobbit.dts > +++ b/arch/arm/boot/dts/imx6dl-pico-hobbit.dts > @@ -13,5 +13,5 @@ > > / { > model = "TechNexion PICO-IMX6 DualLite/Solo Board and Hobbit baseboard"; > - compatible = "technexion,imx6dl-pico", "fsl,imx6dl"; > + compatible = "technexion,imx6dl-pico-hobbit", "fsl,imx6dl"; > }; > diff --git a/arch/arm/boot/dts/imx6dl-pico-nymph.dts b/arch/arm/boot/dts/imx6dl-pico-nymph.dts > index b282dbf953aa..32ccfc5d41ce 100644 > --- a/arch/arm/boot/dts/imx6dl-pico-nymph.dts > +++ b/arch/arm/boot/dts/imx6dl-pico-nymph.dts > @@ -13,5 +13,5 @@ > > / { > model = "TechNexion PICO-IMX6 DualLite/Solo Board and Nymph baseboard"; > - compatible = "technexion,imx6dl-pico", "fsl,imx6dl"; > + compatible = "technexion,imx6dl-pico-nymph", "fsl,imx6dl"; > }; > diff --git a/arch/arm/boot/dts/imx6dl-pico-pi.dts b/arch/arm/boot/dts/imx6dl-pico-pi.dts > index b7b1c07f96f3..4590e8ad9a91 100644 > --- a/arch/arm/boot/dts/imx6dl-pico-pi.dts > +++ b/arch/arm/boot/dts/imx6dl-pico-pi.dts > @@ -13,5 +13,5 @@ > > / { > model = "TechNexion PICO-IMX6 DualLite/Solo Board and PI baseboard"; > - compatible = "technexion,imx6dl-pico", "fsl,imx6dl"; > + compatible = "technexion,imx6dl-pico-pi", "fsl,imx6dl"; > }; > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |