From: Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
Philipp Zabel
<philipp.zabel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Paul Parsons
<lost.distance-/E1597aS9LQAvxtiuMwx3w@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Dave Gerlach <d-gerlach-l0cyMroinI0@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Nishant Menon <nm-l0cyMroinI0@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Suman Anna <s-anna-l0cyMroinI0@public.gmane.org>,
Tero Kristo <t-kristo-l0cyMroinI0@public.gmane.org>
Subject: Re: [PATCH] reset: ti-rstctrl: use the reset-simple driver
Date: Tue, 16 Jan 2018 10:30:54 +0100 [thread overview]
Message-ID: <1516095054.9022.1.camel@pengutronix.de> (raw)
In-Reply-To: <20180116011159.1386-1-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
Hi Tony,
On Mon, 2018-01-15 at 17:11 -0800, Tony Lindgren wrote:
> We can support the RSTCTRL reset registers on many TI SoCs with
> reset-simple.
>
> Cc: Dave Gerlach <d-gerlach-l0cyMroinI0@public.gmane.org>
> Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
> Cc: Nishant Menon <nm-l0cyMroinI0@public.gmane.org>
> Cc: Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> Cc: Suman Anna <s-anna-l0cyMroinI0@public.gmane.org>
> Cc: Tero Kristo <t-kristo-l0cyMroinI0@public.gmane.org>
> Signed-off-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
> ---
>
> That's all there is to it :) Naturally this can wait for v4.17
> if necessary.
>
> ---
> .../devicetree/bindings/reset/ti-rstctrl.txt | 29 ++++++++++++++++++++++
> drivers/reset/Kconfig | 2 +-
> drivers/reset/reset-simple.c | 1 +
> 3 files changed, 31 insertions(+), 1 deletion(-)
> create mode 100644 Documentation/devicetree/bindings/reset/ti-rstctrl.txt
>
> diff --git a/Documentation/devicetree/bindings/reset/ti-rstctrl.txt b/Documentation/devicetree/bindings/reset/ti-rstctrl.txt
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/reset/ti-rstctrl.txt
> @@ -0,0 +1,29 @@
> +TI RSTCTRL Reset Controller
> +
> +Required properties:
> +- compatible : "ti,rstctrl"
> +- reg : Should contain 1 register ranges(address and length)
> +- #reset-cells: 1
> +
> +Example:
> +
> + prcm: prcm@200000 {
> + compatible = "ti,am3-prcm", "simple-bus";
> + reg = <0x200000 0x4000>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0 0x200000 0x4000>;
> +
> + prm_gfx: prm@1100 {
> + compatible = "simple-bus";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0 0x1100 0x100>;
> +
> + gfx_rstctrl: rstctrl@4 {
,->
> + | reg = <0x4 0x4>;
> + | #reset-cells = <1>;
> + `-- compatible = "ti,rstctrl";
Looks good to me. Can I move the compatible property when applying?
> + };
> + };
> + };
> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -83,7 +83,7 @@ config RESET_PISTACHIO
>
> config RESET_SIMPLE
> bool "Simple Reset Controller Driver" if COMPILE_TEST
> - default ARCH_SOCFPGA || ARCH_STM32 || ARCH_STRATIX10 || ARCH_SUNXI || ARCH_ZX
> + default ARCH_OMAP2PLUS || ARCH_SOCFPGA || ARCH_STM32 || ARCH_STRATIX10 || ARCH_SUNXI || ARCH_ZX
> help
> This enables a simple reset controller driver for reset lines that
> that can be asserted and deasserted by toggling bits in a contiguous,
> diff --git a/drivers/reset/reset-simple.c b/drivers/reset/reset-simple.c
> --- a/drivers/reset/reset-simple.c
> +++ b/drivers/reset/reset-simple.c
> @@ -123,6 +123,7 @@ static const struct of_device_id reset_simple_dt_ids[] = {
> { .compatible = "st,stm32-rcc", },
> { .compatible = "allwinner,sun6i-a31-clock-reset",
> .data = &reset_simple_active_low },
> + { .compatible = "ti,rstctrl", },
> { .compatible = "zte,zx296718-reset",
> .data = &reset_simple_active_low },
> { /* sentinel */ },
regards
Philipp
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-01-16 9:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 1:11 [PATCH] reset: ti-rstctrl: use the reset-simple driver Tony Lindgren
[not found] ` <20180116011159.1386-1-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2018-01-16 6:50 ` Tero Kristo
2018-01-16 9:30 ` Philipp Zabel [this message]
2018-01-16 15:03 ` Tony Lindgren
[not found] ` <20180116150314.GC4042-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2018-01-16 21:22 ` Suman Anna
[not found] ` <d32d9836-5edd-d43d-547b-f22384950f2c-l0cyMroinI0@public.gmane.org>
2018-01-16 23:22 ` Tony Lindgren
[not found] ` <20180116232243.GD4042-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2018-01-19 20:22 ` Suman Anna
[not found] ` <10dab35c-9c79-5a77-0654-1e99621e4c0f-l0cyMroinI0@public.gmane.org>
2018-01-19 21:33 ` Tony Lindgren
[not found] ` <20180119213310.GA4180-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2018-01-19 23:29 ` Suman Anna
2018-01-19 23:49 ` Tony Lindgren
[not found] ` <20180119234938.GB4180-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2018-01-20 0:43 ` Suman Anna
2018-01-20 0:55 ` Tony Lindgren
[not found] ` <20180120005551.GC4180-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2018-01-22 17:03 ` Tony Lindgren
2018-03-01 18:14 ` Tony Lindgren
2018-03-02 9:53 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516095054.9022.1.camel@pengutronix.de \
--to=p.zabel-bicnvbalz9megne8c9+irq@public.gmane.org \
--cc=d-gerlach-l0cyMroinI0@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lost.distance-/E1597aS9LQAvxtiuMwx3w@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=nm-l0cyMroinI0@public.gmane.org \
--cc=philipp.zabel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=s-anna-l0cyMroinI0@public.gmane.org \
--cc=t-kristo-l0cyMroinI0@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).