From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94064C433EF for ; Thu, 28 Apr 2022 10:43:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343984AbiD1Kqo (ORCPT ); Thu, 28 Apr 2022 06:46:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343885AbiD1Kqb (ORCPT ); Thu, 28 Apr 2022 06:46:31 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5B1ED86AEC; Thu, 28 Apr 2022 03:43:10 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 963DB1474; Thu, 28 Apr 2022 03:43:10 -0700 (PDT) Received: from [10.57.80.98] (unknown [10.57.80.98]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7EEF53F774; Thu, 28 Apr 2022 03:43:07 -0700 (PDT) Message-ID: <1d1aae6e-50db-d6db-9727-62f9c2d1ca6b@arm.com> Date: Thu, 28 Apr 2022 11:43:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 04/10] arm64: dts: juno: use proper 'dma-channels/requests' properties Content-Language: en-GB To: Krzysztof Kozlowski , Lee Jones , Rob Herring , Krzysztof Kozlowski , Alim Akhtar , Dinh Nguyen , Michal Simek , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Ray Jui , Scott Branden , Broadcom Kernel Team , Sylwester Nawrocki , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Rob Herring References: <20220427155840.596535-1-krzysztof.kozlowski@linaro.org> <20220427155840.596535-5-krzysztof.kozlowski@linaro.org> From: Robin Murphy In-Reply-To: <20220427155840.596535-5-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2022-04-27 16:58, Krzysztof Kozlowski wrote: > pl330 DMA controller bindings documented 'dma-channels' and > 'dma-requests' properties (without leading hash sign), so fix the DTS to > match the bindings. > > Reported-by: Rob Herring > Signed-off-by: Krzysztof Kozlowski > --- > arch/arm64/boot/dts/arm/juno-base.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi > index 4f40a5c8f565..96ef0ddc0b2d 100644 > --- a/arch/arm64/boot/dts/arm/juno-base.dtsi > +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi > @@ -829,8 +829,8 @@ dma-controller@7ff00000 { > compatible = "arm,pl330", "arm,primecell"; > reg = <0x0 0x7ff00000 0 0x1000>; > #dma-cells = <1>; > - #dma-channels = <8>; > - #dma-requests = <32>; > + dma-channels = <8>; > + dma-requests = <32>; BTW, this has always been wrong - Juno is configured with only 8 request interfaces. But then it's moot anyway since PL330 has an ID register for this stuff[1], so the DT properties aren't used by Linux, and shouldn't be needed in general. Thanks, Robin. [1] https://developer.arm.com/documentation/ddi0424/d/programmers-model/register-descriptions/configuration-register-0?lang=en > interrupts = , > , > ,