From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB811C43603 for ; Mon, 9 Dec 2019 10:15:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B6A1A206D5 for ; Mon, 9 Dec 2019 10:15:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="HwguWYyp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727249AbfLIKPa (ORCPT ); Mon, 9 Dec 2019 05:15:30 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:37845 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727247AbfLIKPa (ORCPT ); Mon, 9 Dec 2019 05:15:30 -0500 Received: by mail-wm1-f66.google.com with SMTP id f129so14281060wmf.2 for ; Mon, 09 Dec 2019 02:15:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=TcyeAKWxbs45jp/CfRj2pE3INadVkQJZA/zsi4FujnU=; b=HwguWYypGOrERHEKBqG6yBbaJtfalNYU6k6DcWv9kigbL85xY7HsZi3xywYDWTsVPp KHf8pD/KhFroU7HAsUnm2fBOM0AvcAvKvhu6/lw/osI1eThQuEYsWRCbc0md14+6/sOq 1joqtMyTmfJuvipkL29zWET0eVNo1c3yy2/3ljQvhH3ASCsNjbQMQSO9Kj6FmKNW/fQX KV+B99rwc7GY2Wwq7u46yCEDyWODY2ilmw8zJgQv6ZerL90rUqepxVETfAvJjbcQDH9r OtCPoqZUH8BufkBmygWVHZ81g70kFqvS/SfVSaOPjTllBJ6BHTE5wU3Iea6lugKB9Fhw xvwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=TcyeAKWxbs45jp/CfRj2pE3INadVkQJZA/zsi4FujnU=; b=UVkQAEbdqIcp04GO8kzo2hdjGC1lGzBOEJU2e4latVli548ggKdmh/WJWHxJ/NHunK bXc+C9lK4WDjjr0DaT6Lzgc6ylGeTW/4E+ExXo6LOfDvqMY5nyJS/NEfkazIwNxVWV+a h4HsOYK64EyhD0zCdHwqYQWSu8/ALWrgC5OSjP1sTxe/gUldH/UFAa7fy8JXpgh1/DyT YkWb1GLmnjDZDYbwmXJW0E3NqzWJxiUi782M11kYaeELjvZPZnexMldSEVHeQZF1Qkm6 9cpoay6OZ6xaTiOETSQsGGPB0Rk6IVf9UgMfVWYdc5iwuvg31LAX5UVVQfT+Gwb6FHBS kANg== X-Gm-Message-State: APjAAAXWe+fvu+irIu5Ine46zbMx9AdZ11RxF4gxQnoS8/smdWoAaN6S 9eyZhTNQBrfTYSgYV3BaU82XhA== X-Google-Smtp-Source: APXvYqzllFTCkE0DiwNkEV+3aqKGy90vjjwlpWPCDPLN8xnRxxdHfYXmJTNDkH4yfls7b/VxgydkCg== X-Received: by 2002:a1c:2155:: with SMTP id h82mr24577971wmh.21.1575886527834; Mon, 09 Dec 2019 02:15:27 -0800 (PST) Received: from localhost (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.gmail.com with ESMTPSA id s82sm13064173wms.28.2019.12.09.02.15.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Dec 2019 02:15:27 -0800 (PST) References: <20191206100218.480348-1-jbrunet@baylibre.com> <20191206100218.480348-5-jbrunet@baylibre.com> User-agent: mu4e 1.3.3; emacs 26.2 From: Jerome Brunet To: Martin Blumenstingl Cc: Kevin Hilman , linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] arm64: dts: meson: add libretech-pc boards support In-reply-to: Date: Mon, 09 Dec 2019 11:15:26 +0100 Message-ID: <1jmuc1erep.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sun 08 Dec 2019 at 19:05, Martin Blumenstingl wrote: > Hi Jerome, > > this is looking good overall - I have some questions / nit-picks below > > On Fri, Dec 6, 2019 at 11:02 AM Jerome Brunet wrote: > [...] >> + adc_keys { > on most boards we use "adc-keys" instead of "adc_keys" > > [...] >> + button-onoff { >> + label = "On/Off"; >> + linux,code = ; > based on the label I assumed that the code is KEY_POWER > why is KEY_VENDOR the better choice here? > My bad - The button is labeled with "UPDATE" ... nothing really matches in the KEYs ... so VENDOR it is. I have just copy/pasted the section and forgot to update the rest > [...] >> + cvbs-connector { >> + compatible = "composite-video-connector"; >> + status = "disabled"; > is there CVBS on the board? if I remember correctly the VPU driver > works fine when omitting the CVBS connector > so if the board doesn't have it you may drop the whole node instead of > keeping it disabled The CVBS output could be provided on one the GPIO header. Since it is not really standard, I prefer to keep off and leave to option to easily turn it on if someone wants to use it. I'll had a comment for that. > > [...] >> + leds { >> + compatible = "gpio-leds"; >> + >> + green { >> + label = "librecomputer:green:disk"; > you can use the "function" and "color" properties instead of the (now > deprecated) "label" > > [...] >> +&external_mdio { >> + external_phy: ethernet-phy@0 { >> + reg = <0>; > it would be great to have a comment above which PHY is used on this board > >> + max-speed = <1000>; >> + reset-assert-us = <10000>; >> + reset-deassert-us = <30000>; >> + reset-gpios = <&gpio GPIOZ_14 GPIO_ACTIVE_LOW>; >> + interrupt-parent = <&gpio_intc>; > a comment like /* MAC_INTR on GPIOZ_15 */ would be great here >> + interrupts = <25 IRQ_TYPE_LEVEL_LOW>; > > [...] >> +&pinctrl_periphs { >> + /* >> + * Make sure the reset pin of the usb HUB is driven high to take >> + * it out of reset. >> + */ >> + usb1_rst_pins: usb1_rst_irq { >> + mux { >> + groups = "GPIODV_3"; >> + function = "gpio_periphs"; >> + bias-disable; >> + output-high; >> + }; >> + }; > on other boards (like Odroid-C2) we use a GPIO hog for this. I'm not > sure which one is better > This is at least tied to the related device. I have discussed "hog" vs "pinctrl" matter with Bartosz Golaszewski and we could not find any reason not proceed with pinctrl when possible. > [...] >> +&pinctrl_periphs { >> + /* >> + * Make sure the irq pin of the TYPE C controller is not driven >> + * by the SoC. > is this because the SoC default configuration pulls the IRQ line LOW, > which then generates "phantom" IRQs? No. It is just making sure the pin is claimed and properly configured. Since our interrupt and gpio controller are completly de-coupled it is not necessarily the case without it (... and yes, the same is true for the other device using gpio irqs) > > [...] >> + fusb302@22 { > typec-portc@22 > > [...] >> + interrupt-parent = <&gpio_intc>; >> + interrupts = <59 IRQ_TYPE_LEVEL_LOW>; > a comment above with the GPIO number would be great > > > Martin