From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Reichel Subject: Re: [PATCHv4 1/3] Input: twl4030-pwrbutton - add device tree support Date: Thu, 24 Oct 2013 10:38:39 +0200 Message-ID: <20131024083837.GA28938@earth.universe> References: <1382550852-11508-1-git-send-email-sre@debian.org> <1382550852-11508-2-git-send-email-sre@debian.org> <5268D095.3060302@epfl.ch> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="WIyZ46R2i8wDzkSu" Return-path: Content-Disposition: inline In-Reply-To: <5268D095.3060302@epfl.ch> Sender: linux-input-owner@vger.kernel.org To: Florian Vaussard Cc: Dmitry Torokhov , Grant Likely , Rob Herring , Peter Ujfalusi , Sachin Kamat , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org --WIyZ46R2i8wDzkSu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Florian, On Thu, Oct 24, 2013 at 09:47:33AM +0200, Florian Vaussard wrote: > > +Required SoC Specific Properties: > > +- compatible: should be one of the following > > + - "ti,twl4030-pwrbutton": For controllers compatible with twl4030 > > +- interrupt: should be one of the following > > + - <8>: For controllers compatible with twl4030 >=20 > This is <8> for your particular case, but it will depend on your > SoC, won't it? Moreover, this property will be most likely > inherited from the root twl node, so I do not see the need to > document it here. See: >=20 > Documentation/devicetree/bindings/mfd/twl-familly.txt No. This is an internal twl4030 interrupt. TWL4030 functions itself as an interrupt controller. > > + > > +Example: > > + twl_pwrbutton: pwrbutton { > > + compatible =3D "ti,twl4030-pwrbutton"; > > + interrupts =3D <8>; > > + }; >=20 > You are missing the root twl node here, no? So should I document it like this? twl4030 { compatible =3D "ti,twl4030"; pwrbutton { compatible =3D "ti,twl4030-pwrbutton"; interrupts =3D <8>; }; }; > > diff --git a/drivers/input/misc/twl4030-pwrbutton.c b/drivers/input/mis= c/twl4030-pwrbutton.c > > index b9a05fd..a3a0fe3 100644 > > --- a/drivers/input/misc/twl4030-pwrbutton.c > > +++ b/drivers/input/misc/twl4030-pwrbutton.c >=20 > Missing #include ? It's included indirectly, but I should probably add a direct include. Thanks. > Best regards, Thanks for the comments. I will sent out an updated patchset later. -- Sebastian --WIyZ46R2i8wDzkSu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) iQIcBAEBCAAGBQJSaNyNAAoJENju1/PIO/qaviEQAJgWOewpGQxQ0hPJP325+1Rm LVM5YxDke2xPKWteEDgEnOjGlgZjqOGU9ZwW5bOTc9yB7M0vlPK1qS9hKjF/7nRS cKPsoXo/8JxgfBjo9eBsUoXPv1gO/QpwBisLtiVfcQFDlSZlWYMwuQtD+rrdEUbq whTUvniz9vmGk3dyRFOWch7B6PGjVXA2rjrr7FzO5MgmfWgR8RlTQCFVm3I65wNM DYNfsTF/Mbah40wwJohF/QDk+4ZQKUbq5NLZKpO+yFR/Pc/IK2ePRaGVLl9WFv98 uGWu99FvJ9gZq5K8N7WAWJWxaj456+6PXts6TlXQbUhWRrPa4xfFs5F9CQ6AKpsb 4AmB2WYEt2r9SEcX8VYHMKCXQVy0/3O2DUiFpFzJUVcp4SqfRshhfP8L4vFU+6fz K0GmT2joL+gwcBqkRZ+Di1+uD4OrwfBKIxVG0YK38T1DNpZGJB2W3P62t0839Fmw tS1vUJnX6vOfbAbWTDLNz9iOBMqzFBX8cojZ9L0MAAHmbVra1OEMDjMXmdPp0J30 P6vcV6PBFXMtt0X1DJLdGtx5Pl7paelKQGCgJI5YE2PBUWNQb7AvaTUhcjWO1rW+ g8O7nmgIbwLjMZmJYjFaxx5V0kNroB23iPmgP2/9XLJekLdBlisQxjD99JDoH4f1 4UBQQJEH3fkIPCE2jl2f =KrTs -----END PGP SIGNATURE----- --WIyZ46R2i8wDzkSu--