From: Rob Herring <robh@kernel.org>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: Shawn Guo <shawnguo@kernel.org>,
Fugang Duan <fugang.duan@nxp.com>,
devicetree@vger.kernel.org, patchwork-lst@pengutronix.de,
kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org,
netdev@vger.kernel.org
Subject: Re: [PATCH v2 1/2] ARM: imx6: disable deeper idle states when FEC is active w/o HW workaround
Date: Mon, 6 Jun 2016 09:33:11 -0500 [thread overview]
Message-ID: <20160606143311.GA21103@rob-hp-laptop> (raw)
In-Reply-To: <1464971480-9203-1-git-send-email-l.stach@pengutronix.de>
On Fri, Jun 03, 2016 at 06:31:19PM +0200, Lucas Stach wrote:
> The i.MX6 Q/DL has an erratum (ERR006687) that prevents the FEC from
> waking the CPUs when they are in wait(unclocked) state. As the hardware
> workaround isn't applicable to all boards, disable the deeper idle state
> when the workaround isn't present and the FEC is in use.
>
> This allows to safely run a kernel with CPUidle enabled on all i.MX6
> boards.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> Acked-by: David S. Miller <davem@davemloft.net> (for network changes)
> ---
> v2: Spell out "workaround" to avoid confusion.
> ---
> Documentation/devicetree/bindings/net/fsl-fec.txt | 3 +++
Acked-by: Rob Herring <robh@kernel.org>
> arch/arm/mach-imx/cpuidle-imx6q.c | 16 +++++++++++++++
> drivers/net/ethernet/freescale/fec.h | 2 ++
> drivers/net/ethernet/freescale/fec_main.c | 12 +++++++++++
> include/soc/imx/cpuidle.h | 25 +++++++++++++++++++++++
> 5 files changed, 58 insertions(+)
> create mode 100644 include/soc/imx/cpuidle.h
next prev parent reply other threads:[~2016-06-06 14:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 16:31 [PATCH v2 1/2] ARM: imx6: disable deeper idle states when FEC is active w/o HW workaround Lucas Stach
2016-06-03 16:31 ` [PATCH v2 2/2] ARM: dts: imx6: tag boards that have the HW workaround for ERR006687 Lucas Stach
2016-06-06 2:00 ` [PATCH v2 1/2] ARM: imx6: disable deeper idle states when FEC is active w/o HW workaround Fugang Duan
2016-06-06 11:04 ` Holger Schurig
2016-06-07 1:40 ` Fugang Duan
[not found] ` <VI1PR0401MB1855AA40FA576AF677A68E6FFF5C0-9IDQY6o3qQgSuE83DPDYPY3W/0Ik+aLCnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2016-06-09 9:35 ` Lucas Stach
2016-06-13 1:17 ` Fugang Duan
2016-06-06 14:33 ` Rob Herring [this message]
2016-06-11 9:04 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160606143311.GA21103@rob-hp-laptop \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fugang.duan@nxp.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=patchwork-lst@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).