From: Rob Herring <robh@kernel.org>
To: Chunyan Zhang <zhang.chunyan@linaro.org>
Cc: Mark Brown <broonie@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Ulf Hansson <ulf.hansson@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
Chunyan Zhang <zhang.lyra@gmail.com>
Subject: Re: [PATCH v3 1/5] bindings: regulator: added support for suspend states
Date: Fri, 19 Jan 2018 16:11:08 -0600 [thread overview]
Message-ID: <20180119221108.nndgk3ln573n6zew@rob-hp-laptop> (raw)
In-Reply-To: <1515752305-15907-2-git-send-email-zhang.chunyan@linaro.org>
On Fri, Jan 12, 2018 at 06:18:21PM +0800, Chunyan Zhang wrote:
> Some systems need to set regulators to specific states when they enter
> low power modes, especially around CPUs. There are many of these modes
> depending on the particular runtime state.
>
> Currently the regulator consumers are not granted permission to change
> suspend state of regulator devices, the constraints are configured at
> startup. In order to allow changes in a vlotage range, we need to add
> new properties for voltage range and a flag to give permission to
> change the suspend voltage and suspend on/off in suspend mode.
>
> Signed-off-by: Chunyan Zhang <zhang.chunyan@linaro.org>
> ---
> Documentation/devicetree/bindings/regulator/regulator.txt | 15 +++++++++++++--
> 1 file changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/regulator/regulator.txt b/Documentation/devicetree/bindings/regulator/regulator.txt
> index 378f6dc..532e286 100644
> --- a/Documentation/devicetree/bindings/regulator/regulator.txt
> +++ b/Documentation/devicetree/bindings/regulator/regulator.txt
> @@ -42,8 +42,19 @@ Optional properties:
> - regulator-state-[mem/disk] node has following common properties:
> - regulator-on-in-suspend: regulator should be on in suspend state.
> - regulator-off-in-suspend: regulator should be off in suspend state.
> - - regulator-suspend-microvolt: regulator should be set to this voltage
> - in suspend.
> + - regulator-suspend-min-microvolt: minimum voltage may be set in
> + suspend state.
> + - regulator-suspend-max-microvolt: maximum voltage may be set in
> + suspend state.
> + - regulator-suspend-microvolt: the default voltage which regulator
> + would be set in suspend. The voltage for suspend also can be
> + adjusted among {regulator-suspend-min-microvolt,
> + regulator-suspend-max-microvolt} by calling
> + regulator_set_suspend_voltage(). This property is now deprecated,
> + setting voltage for suspend mode via API the regulator driver
> + provides is recommended.
Please reword. This is Linux implementation details that shouldn't be in
the binding.
> + - regulator-changeable-in-suspend: whether the default voltage and
> + the regulator on/off in suspend can be changed in runtime.
> - regulator-mode: operating mode in the given suspend state.
> The set of possible operating modes depends on the capabilities of
> every hardware so the valid modes are documented on each regulator
> --
> 2.7.4
>
next prev parent reply other threads:[~2018-01-19 22:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 10:18 [PATCH v3 0/5] Add regulator suspend and resume support Chunyan Zhang
2018-01-12 10:18 ` [PATCH v3 1/5] bindings: regulator: added support for suspend states Chunyan Zhang
2018-01-19 22:11 ` Rob Herring [this message]
2018-01-22 2:16 ` Chunyan Zhang
[not found] ` <1515752305-15907-2-git-send-email-zhang.chunyan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2018-01-22 7:59 ` [PATCH V4 " Chunyan Zhang
2018-01-22 19:50 ` Rob Herring
2018-01-23 11:28 ` Mark Brown
[not found] ` <1516607961-379-1-git-send-email-zhang.chunyan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2018-01-26 15:26 ` Applied "regulator: added support for suspend states" to the regulator tree Mark Brown
2018-01-12 10:18 ` [PATCH v3 2/5] regulator: make regulator voltage be an array to support more states Chunyan Zhang
2018-01-12 10:18 ` [PATCH v3 3/5] drivers: regulator: leave one item to record whether regulator is enabled Chunyan Zhang
2018-01-26 15:26 ` Applied "regulator: leave one item to record whether regulator is enabled" to the regulator tree Mark Brown
[not found] ` <1515752305-15907-1-git-send-email-zhang.chunyan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2018-01-12 10:18 ` [PATCH v3 4/5] drivers: regulator: empty the old suspend functions Chunyan Zhang
2018-01-12 10:18 ` [PATCH v3 5/5] regulator: add PM suspend and resume hooks Chunyan Zhang
2018-01-12 10:23 ` [PATCH v3 0/5] Add regulator suspend and resume support Chunyan Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180119221108.nndgk3ln573n6zew@rob-hp-laptop \
--to=robh@kernel.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=zhang.chunyan@linaro.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).