From: Sudeep Holla <sudeep.holla@arm.com>
To: Jassi Brar <jassisinghbrar@gmail.com>
Cc: Morten Borup Petersen <morten_bp@live.dk>,
Tushar Khandelwal <tushar.khandelwal@arm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"tushar.2nov@gmail.com" <tushar.2nov@gmail.com>,
"nd@arm.com" <nd@arm.com>,
Morten Borup Petersen <morten.petersen@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Devicetree List <devicetree@vger.kernel.org>,
Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH 1/4] mailbox: arm_mhuv2: add device tree binding documentation
Date: Wed, 14 Aug 2019 11:05:18 +0100 [thread overview]
Message-ID: <20190814100518.GA21898@e107155-lin> (raw)
In-Reply-To: <CABb+yY3Ni7wV+ui1LO7TERWQH_BoakZbPq961wdRPB4X-nwS2A@mail.gmail.com>
On Tue, Aug 13, 2019 at 11:36:56AM -0500, Jassi Brar wrote:
[...]
> > >>
> > >> As mentioned in the response to your initial comment, the driver does
> > >> not currently support mixing protocols.
> > >>
> > > Thanks for acknowledging that limitation. But lets also address it.
> > >
> >
> > We are hesitant to dedicate time to developing mixing protocols given
> > that we don't have any current usecase nor any current platform which
> > would support this.
> >
> Can you please share the client code against which you tested this driver?
> From my past experience, I realise it is much more efficient to tidyup
> the code myself, than endlessly trying to explain the benefits.
>
Thanks for the patience and offer. Can we try the same with MHUv1 and SCMI
upstream driver.
The firmware just uses High Priority physical channel bit 0 and 2 as Tx
and bit 1 and 3 as Rx. Bit 2 and 3 are for perf which shouldn't get blocked
by bit 0 and 1. I mean I can have 10 requests covering clocks/sensors and
others on bit 0 and 1, but the bits 2 and 3 are dedicated for DVFS and
shouldn't be blocked because of other non DVFS requests.
The DT looks something like this(modified MHU binding for 2 cells)
mailbox: mhu@2b1f0000 {
compatible = "arm,primecell";
reg = <0x0 0x2b1f0000 0x0 0x1000>;
interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>;
interrupt-names = "mhu_lpri_rx",
"mhu_hpri_rx";
#mbox-cells = <2>;
mbox-name = "ARM-MHU";
clocks = <&soc_refclk100mhz>;
clock-names = "apb_pclk";
};
firmware {
scmi {
compatible = "arm,scmi";
mbox-names = "tx", "rx";
mboxes = <&mailbox 0 0 &mailbox 0 1>;
#address-cells = <1>;
#size-cells = <0>;
scmi_devpd: protocol@11 {
reg = <0x11>;
#power-domain-cells = <1>;
};
scmi_dvfs: protocol@13 {
reg = <0x13>;
#clock-cells = <1>;
mbox-names = "tx", "rx";
mboxes = <&mailbox 0 2 &mailbox 0 3>;
};
scmi_clk: protocol@14 {
reg = <0x14>;
#clock-cells = <1>;
};
scmi_sensors0: protocol@15 {
reg = <0x15>;
#thermal-sensor-cells = <1>;
};
};
};
--
Regards,
Sudeep
next prev parent reply other threads:[~2019-08-14 10:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190717192616.1731-1-tushar.khandelwal@arm.com>
2019-07-17 19:26 ` [PATCH 1/4] mailbox: arm_mhuv2: add device tree binding documentation Tushar Khandelwal
2019-07-21 21:58 ` Jassi Brar
2019-07-25 5:49 ` Jassi Brar
2019-07-28 21:28 ` Morten Borup Petersen
2019-07-31 7:31 ` Jassi Brar
2019-08-02 10:41 ` Morten Borup Petersen
2019-08-13 16:36 ` Jassi Brar
2019-08-14 10:05 ` Sudeep Holla [this message]
2019-08-14 14:52 ` Jassi Brar
2019-08-14 16:51 ` Sudeep Holla
2019-08-14 22:22 ` tushar.khandelwal
2019-08-14 22:20 ` tushar.khandelwal
2019-08-02 10:53 ` Sudeep Holla
2019-08-07 11:11 ` Tushar Khandelwal
2019-07-28 21:27 ` Morten Borup Petersen
2019-08-02 10:59 ` Sudeep Holla
2019-08-07 11:17 ` Tushar Khandelwal
2019-08-07 11:32 ` Tushar K
2019-08-08 10:31 ` Morten Borup Petersen
2019-07-17 19:26 ` [PATCH 2/4] mailbox: arm_mhuv2: add arm mhuv2 driver Tushar Khandelwal
2019-07-17 19:26 ` [PATCH 3/4] mailbox: arm_mhuv2: add doorbell transport protocol operations Tushar Khandelwal
2019-07-17 19:26 ` [PATCH 4/4] mailbox: arm_mhuv2: add multi word " Tushar Khandelwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190814100518.GA21898@e107155-lin \
--to=sudeep.holla@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=morten.petersen@arm.com \
--cc=morten_bp@live.dk \
--cc=nd@arm.com \
--cc=robh+dt@kernel.org \
--cc=tushar.2nov@gmail.com \
--cc=tushar.khandelwal@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).