From: Vincent Whitchurch <vincent.whitchurch@axis.com>
To: Frank Rowand <frowand.list@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
"pantelis.antoniou@konsulko.com" <pantelis.antoniou@konsulko.com>,
Pantelis Antoniou <panto@antoniou-consulting.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"geert@linux-m68k.org" <geert@linux-m68k.org>,
Alan Tull <atull@kernel.org>
Subject: Re: [PATCH] of: overlay: add_changeset_property() memory leak
Date: Mon, 25 Nov 2019 16:17:47 +0100 [thread overview]
Message-ID: <20191125151747.hqm55drde5ldkrte@axis.com> (raw)
In-Reply-To: <9eda204f-aaa0-54a1-83eb-a012ddeeaac3@gmail.com>
On Thu, Nov 21, 2019 at 08:20:21PM +0100, Frank Rowand wrote:
> On 11/21/19 1:16 PM, frowand.list@gmail.com wrote:
> > From: Frank Rowand <frank.rowand@sony.com>
> >
> > No changeset entries are created for #address-cells and #size-cells
> > properties, but the duplicated properties are never freed. This
> > results in a memory leak which is detected by kmemleak:
> >
> > unreferenced object 0x85887180 (size 64):
> > backtrace:
> > kmem_cache_alloc_trace+0x1fb/0x1fc
> > __of_prop_dup+0x25/0x7c
> > add_changeset_property+0x17f/0x370
> > build_changeset_next_level+0x29/0x20c
> > of_overlay_fdt_apply+0x32b/0x6b4
> > ...
> >
> > Fixes: 6f75118800acf77f8 ("of: overlay: validate overlay properties #address-cells and #size-cells")
> > Reported-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
> > Signed-off-by: Frank Rowand <frank.rowand@sony.com>
>
> Can you please check whether this patch fixes the memleak that you
> found and fixed in "[PATCH 1/2] of: overlay: fix properties memory leak"?
Tested-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
Thanks.
next prev parent reply other threads:[~2019-11-25 15:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 19:16 [PATCH] of: overlay: add_changeset_property() memory leak frowand.list
2019-11-21 19:20 ` Frank Rowand
2019-11-25 15:17 ` Vincent Whitchurch [this message]
2019-11-26 19:23 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191125151747.hqm55drde5ldkrte@axis.com \
--to=vincent.whitchurch@axis.com \
--cc=atull@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pantelis.antoniou@konsulko.com \
--cc=panto@antoniou-consulting.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).