From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF462C43603 for ; Mon, 9 Dec 2019 08:04:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 83D1820721 for ; Mon, 9 Dec 2019 08:04:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="ILwltwmy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727044AbfLIIEw (ORCPT ); Mon, 9 Dec 2019 03:04:52 -0500 Received: from mail-mw2nam10on2067.outbound.protection.outlook.com ([40.107.94.67]:54163 "EHLO NAM10-MW2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727160AbfLIIEw (ORCPT ); Mon, 9 Dec 2019 03:04:52 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I3dyaluwSxepCAHcZgMiI6fYb2PPuQI89wwDte5NVaAOoqSzt8BSm5wxKS9J/rYcr6iDxGquUwZ0A8AlItbJ+yJKv0/CLEXfKymnmpwvRGdlnkmR1qArDOK6cDtsvYL/HF9kYUHSkG8MNWkGRzDtkSEJ7Sn/+lvfiMkbREJslaMJ3FchGTz0/ZjBAQZ1vaE/6hfjWGh4s4P/7ebmKRXQ47j/Z4cl8kzNEz0gO1pkPW4L2a9qSE6GrTapsa9WFHyyA4aysrsAsE/lpzdXQe1OFF1wQC8igQr0i8EYED+5r3C/LWHUY9ULVnIgflu8Goeb5K3ALz4GcSdEwLpAMsbtMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lHpirNoQllot/qAGqgDmO3BbQ2FDjvALdZ+gDs90Qgk=; b=Un0R8tAcTytfQANChGaZ7UQohRW2Tj3OSK6BfNO2KWHv9tuX/pTScQF0HNdVbW8QkQFDwt3QMZRhAs1pVaQxOGCE34g8pVHbc2JZ9BuPiqBYl8P9mNvWMvmbJWwcRUE4wOLrpFgnYEN7toLAcQ1LCOGKXx0dYLFFVGr7orUvPLSBFe7tCE6T7jjz0s84MR5RYXLKwhW5CgcAF98FFU/gOQ8/oAquhVsD9tNU4D78TLtCOCdGLsAhnfygUxc4vSrsNVCsATMagEYR8k1R+lBMLDCHu6mZiPLKkROORfe2rGI7xXGrskKFx/3TachdOBmlHResBs32+0YxBOqwtJjjlg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.60.83) smtp.rcpttodomain=roeck-us.net smtp.mailfrom=xilinx.com; dmarc=bestguesspass action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lHpirNoQllot/qAGqgDmO3BbQ2FDjvALdZ+gDs90Qgk=; b=ILwltwmyDklb/IThVZdaSu9dB07xEE0kG3AY9//59DYnUCC7mPldRDBqOKLyHVb79JclqLrOrZFOWeSBhJWaOhvn104/L9XBTu7kKi8gvfwEFyjBuw4ixxaJnX2Wu/LLIppqBnVJy0+nimqVOkrd0pGrtNtByFAa4Vv7kMw2W+w= Received: from MWHPR02CA0002.namprd02.prod.outlook.com (2603:10b6:300:4b::12) by BY5PR02MB6517.namprd02.prod.outlook.com (2603:10b6:a03:1dc::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2516.14; Mon, 9 Dec 2019 08:04:09 +0000 Received: from BL2NAM02FT006.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e46::203) by MWHPR02CA0002.outlook.office365.com (2603:10b6:300:4b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2516.12 via Frontend Transport; Mon, 9 Dec 2019 08:04:08 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; roeck-us.net; dkim=none (message not signed) header.d=none;roeck-us.net; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01; Received: from xsj-pvapsmtpgw01 (149.199.60.83) by BL2NAM02FT006.mail.protection.outlook.com (10.152.76.239) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.2495.26 via Frontend Transport; Mon, 9 Dec 2019 08:04:08 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw01 with esmtp (Exim 4.63) (envelope-from ) id 1ieE1O-00051f-Pq; Mon, 09 Dec 2019 00:03:58 -0800 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1ieE1J-0001PT-Me; Mon, 09 Dec 2019 00:03:53 -0800 Received: from [10.71.117.222] (helo=localhost) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1ieE1E-0001Mf-5n; Mon, 09 Dec 2019 00:03:48 -0800 Date: Mon, 9 Dec 2019 08:48:40 +0100 From: "Edgar E. Iglesias" To: Guenter Roeck Cc: Michal Simek , Michael Tretter , Edgar Iglesias , robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, Rajan Vaja , Rajan Vaja , linux-arm-kernel@lists.infradead.org, qemu-devel@nongnu.org Subject: Re: [PATCH 1/5] arm64: zynqmp: Add firmware DT node Message-ID: <20191209074840.GP32392@toto> References: <20191018160735.15658-1-m.tretter@pengutronix.de> <20191018160735.15658-2-m.tretter@pengutronix.de> <20191208223814.GA21260@roeck-us.net> <4821742f-2d60-b722-b954-263de975bf2e@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4821742f-2d60-b722-b954-263de975bf2e@roeck-us.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.2.0.1013-23620.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(4636009)(7916004)(39860400002)(136003)(396003)(376002)(346002)(199004)(189003)(336012)(70206006)(50466002)(70586007)(26005)(36386004)(6916009)(186003)(5660300002)(53546011)(6666004)(426003)(356004)(316002)(76176011)(58126008)(54906003)(966005)(2906002)(478600001)(1076003)(33656002)(76506006)(9686003)(8936002)(8676002)(81156014)(57986006)(4326008)(305945005)(229853002)(33716001)(81166006)(9786002);DIR:OUT;SFP:1101;SCL:1;SRVR:BY5PR02MB6517;H:xsj-pvapsmtpgw01;FPR:;SPF:Pass;LANG:en;PTR:unknown-60-83.xilinx.com;A:1;MX:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 99d3363b-7ba9-49f0-8e36-08d77c7e5e43 X-MS-TrafficTypeDiagnostic: BY5PR02MB6517: X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-Forefront-PRVS: 02462830BE X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NBr13pZoCi8wycUbsH7Yx6ioBJK8vJD+gB3KKvU2z5iweCsGuUIwuvwaucSzYXEwlHwdyyCxI398lXUygfKxTXFV22SaYrt2yPhZ6F3cDxxIxVrd588jx+1IpjMaC6cZVaY8OJh/E0H9RgDhEnUaNA2DA0lCUqk3IRR431XPI5wGHUMQC8ld7DN0UoILwtU14tgq8nkByTjUyes7fBHn4TEJaWtlhiXrVnpPmTWH9plma9JzG1C1uSyVd7Oxmbsfq908hPAJ6okeoDd98p6IQ5LHPKIw9lwozl43Bd2inbfPkGxhgDPkIICrB3iGP1m1YxXU57MbEObLbtOe0jrCLooHm/Y6XZrH78hD/Emm5SZzOcJa4waxY6koI5sVER52lXTsn8YYkZbLWtAbNW0pAkLr17XDlNRo/qCJhnnL0Iv0AjfHvOh3JyZr/iNOK3DT0gKgGjvj4TI4kXWEc1wUk5YkI9Threy1Oe6nSV73HBU= X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2019 08:04:08.3692 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 99d3363b-7ba9-49f0-8e36-08d77c7e5e43 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR02MB6517 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sun, Dec 08, 2019 at 11:19:33PM -0800, Guenter Roeck wrote: > On 12/8/19 10:42 PM, Michal Simek wrote: > > Hi, +Edgar > > > > > > On 08. 12. 19 23:38, Guenter Roeck wrote: > > > On Fri, Oct 18, 2019 at 06:07:31PM +0200, Michael Tretter wrote: > > > > From: Rajan Vaja > > > > > > > > Add firmware DT node in ZynqMP device tree. This node > > > > uses bindings as per new firmware interface driver. > > > > > > > > Signed-off-by: Rajan Vaja > > > > Signed-off-by: Michal Simek > > > > Signed-off-by: Michael Tretter > > > > > > With this patch applied in the mainline kernel, the qemu xlnx-zcu102 > > > emulation crashes (see below). Any idea what it might take to get > > > qemu back to working ? > > > > Driver talks through ATF to PMU unit(microblaze). I don't think A53+MB > > concept is working with mainline qemu. But crash is too hard. It should Yes, QEMU doesn't support the Cortex-A53s along with the PMU MicroBlaze. My workaround when using upstream QEMU is a modified DT without the PMU firmware and with fixed-clock nodes. > > be no response from PMU and then this panic. > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/firmware/xilinx/zynqmp.c?h=v5.5-rc1#n728 > > > > Isn't that a bit harsh too ? Normally one would print an error message > and abort driver instantiation. I agree, it would be nice if ATF & kernel drivers would somehow handle this more gracefully. Cheers, Edgar > > It sounds like you are saying that qemu's xlnx-zcu102 emulation is > no longer supported and expected to crash the kernel. Is this a > correct assumption ? If so, I'll drop it from my list of tests. > > Thanks, > Guenter