From: Maxime Ripard <mripard@kernel.org>
To: "Clément Péron" <peron.clem@gmail.com>
Cc: Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
devicetree <devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: allwinner: Convert to new-style SPDX license identifiers
Date: Mon, 9 Dec 2019 17:53:14 +0100 [thread overview]
Message-ID: <20191209165314.mostdak54qgo2r3y@gilmour.lan> (raw)
In-Reply-To: <CAJiuCcdKi9vedvCWz1BvCS8B0h9rEX1oafZzdok9noFsnvg1NA@mail.gmail.com>
On Mon, Dec 02, 2019 at 08:45:44PM +0100, Clément Péron wrote:
> > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> > > > > index f335f7482a73..84b7e9936300 100644
> > > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> > > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> > > > > @@ -1,4 +1,4 @@
> > > > > -// SPDX-License-Identifier: (GPL-2.0+ or MIT)
> > > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > > > > /*
> > > > > * Copyright (C) 2019 Clément Péron <peron.clem@gmail.com>
> > > > > */
> > > >
> > > > And I'm not sure what this one (and the next) is?
> > >
> > > The license expressions in dual licensed files is wrong here, "OR"
> > > should be uppercase.
> > > I can move it to a separate commit if you like.
> >
>
> > Ah, right, indeed, this should be in a separate patch.
> So how many patch do you recommend here ?
>
> 1 for the or -> OR style fix.
> 1 to change to SPDX.
> and 1 to use the same // style everywhere ?
Yep :)
Maxime
prev parent reply other threads:[~2019-12-09 16:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-23 13:24 [PATCH] arm64: dts: allwinner: Convert to new-style SPDX license identifiers Clément Péron
2019-11-28 17:42 ` Maxime Ripard
2019-11-28 18:12 ` Clément Péron
2019-12-02 19:12 ` Maxime Ripard
2019-12-02 19:45 ` Clément Péron
2019-12-09 16:53 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191209165314.mostdak54qgo2r3y@gilmour.lan \
--to=mripard@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=peron.clem@gmail.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).