devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: "André Hentschel" <nerv@dawncrow.de>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
	linux@arm.linux.org.uk, linux-kernel@vger.kernel.org,
	robh+dt@kernel.org, bcousson@baylibre.com,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/2] ARM: dts: Move interconnect target module for omap3 sgx to separate dtsi files
Date: Thu, 2 Jan 2020 13:20:00 -0800	[thread overview]
Message-ID: <20200102212000.GG16702@atomide.com> (raw)
In-Reply-To: <9e39831c-bfa8-d497-7d3e-ff6ec04b8e52@dawncrow.de>

* André Hentschel <nerv@dawncrow.de> [200102 21:16]:
> Am 02.01.20 um 20:33 schrieb Tony Lindgren:
> > * André Hentschel <nerv@dawncrow.de> [191230 20:22]:
> >> Only dm3730 and am3715 come with SGX support
> > 
> > AFAIK dm3730 is just a marketing name for a catalog version of
> > omap3630. So using omap36xx.dtsi is correct and we should not
> > change that.
> > 
> > Can you please just add a minimal dm3725.dtsi that your board dts
> > can include and avoid disabling sgx in the board specific file?
> > That is assuming you have dm3725 with dsp and isp but no sgx.
> 
> I removed the sgx disable part already in 2/2.
> Consulting my table:
>      DM3730 | DM3725 | AM3715 | AM3703
> DSP    X    |   X    |        |    
> SGX    X    |        |   X    |    
> Where X is "supported"
> 
> So including omap63xx.dtsi seems right after this patch moves the
> sgx part to separate dtsi. Or do you want to have the sxg
> disabling in the dm3725.dtsi?

Yes please just add a minimal dm3725.dtsi including omap36xx.dtsi
and setting sgx to status = "disabled". And then you can include
dm3725.dtsi from your board specific dts file.

> > You can read the detected SoC with:
> > 
> > # cat /sys/bus/soc/devices/soc0/machine
> 
> # cat /sys/bus/soc/devices/soc0/machine
> DM3725
> # cat /sys/bus/soc/devices/soc0/revision 
> ES1.2

OK yeah makes sense for that product as potentially only the dsp
is used for audio.

Regards,

Tony

      reply	other threads:[~2020-01-02 21:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-30 20:20 [PATCH v2 1/2] ARM: dts: Move interconnect target module for omap3 sgx to separate dtsi files André Hentschel
2019-12-30 20:20 ` [PATCH v2 2/2] ARM: dts: Add omap3-echo André Hentschel
2020-01-02 19:33 ` [PATCH v2 1/2] ARM: dts: Move interconnect target module for omap3 sgx to separate dtsi files Tony Lindgren
2020-01-02 21:15   ` André Hentschel
2020-01-02 21:20     ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200102212000.GG16702@atomide.com \
    --to=tony@atomide.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=nerv@dawncrow.de \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).