From: Rob Herring <robh@kernel.org>
To: Khouloud Touil <ktouil@baylibre.com>
Cc: bgolaszewski@baylibre.com, mark.rutland@arm.com,
srinivas.kandagatla@linaro.org, baylibre-upstreaming@groups.io,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-i2c@vger.kernel.org, linus.walleij@linaro.org
Subject: Re: [PATCH v3 3/4] dt-bindings: at24: remove the optional property write-protect-gpios
Date: Fri, 3 Jan 2020 16:44:25 -0700 [thread overview]
Message-ID: <20200103234425.GA17746@bogus> (raw)
In-Reply-To: <20191219115141.24653-4-ktouil@baylibre.com>
On Thu, Dec 19, 2019 at 12:51:40PM +0100, Khouloud Touil wrote:
> NVMEM framework is an interface for the at24 EEPROMs as well as for
> other drivers, instead of passing the wp-gpios over the different
> drivers each time, it would be better to pass it over the NVMEM
> subsystem once and for all.
>
> Removing the optional property form the device tree binding document.
>
> Signed-off-by: Khouloud Touil <ktouil@baylibre.com>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> Documentation/devicetree/bindings/eeprom/at24.yaml | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Documentation/devicetree/bindings/eeprom/at24.yaml
> index e8778560d966..75de83708146 100644
> --- a/Documentation/devicetree/bindings/eeprom/at24.yaml
> +++ b/Documentation/devicetree/bindings/eeprom/at24.yaml
> @@ -145,10 +145,7 @@ properties:
> over reads to the next slave address. Please consult the manual of
> your device.
>
> - wp-gpios:
> - description:
> - GPIO to which the write-protect pin of the chip is connected.
> - maxItems: 1
> + wp-gpios: true
>
> address-width:
> allOf:
> @@ -181,7 +178,6 @@ examples:
> compatible = "microchip,24c32", "atmel,24c32";
> reg = <0x52>;
> pagesize = <32>;
> - wp-gpios = <&gpio1 3 0>;
This is still valid, why is it being removed?
> num-addresses = <8>;
> };
> };
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-01-03 23:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 11:51 [PATCH v3 0/4] at24: move write-protect pin handling to nvmem core Khouloud Touil
2019-12-19 11:51 ` [PATCH v3 1/4] dt-bindings: nvmem: new optional property write-protect-gpios Khouloud Touil
2020-01-03 23:40 ` Rob Herring
2019-12-19 11:51 ` [PATCH v3 2/4] nvmem: add support for the write-protect pin Khouloud Touil
2019-12-19 11:51 ` [PATCH v3 3/4] dt-bindings: at24: remove the optional property write-protect-gpios Khouloud Touil
2020-01-03 23:44 ` Rob Herring [this message]
2019-12-19 11:51 ` [PATCH v3 4/4] eeprom: at24: remove the write-protect pin support Khouloud Touil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200103234425.GA17746@bogus \
--to=robh@kernel.org \
--cc=baylibre-upstreaming@groups.io \
--cc=bgolaszewski@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=ktouil@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).