From: Thierry Reding <thierry.reding@gmail.com>
To: Nagarjuna Kristam <nkristam@nvidia.com>
Cc: balbi@kernel.org, gregkh@linuxfoundation.org,
jonathanh@nvidia.com, mark.rutland@arm.com, robh+dt@kernel.org,
kishon@ti.com, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [Patch V3 12/18] usb: gadget: tegra-xudc: support multiple device modes
Date: Wed, 29 Jan 2020 10:27:28 +0100 [thread overview]
Message-ID: <20200129092728.GB2479935@ulmo> (raw)
In-Reply-To: <7478f53a-c236-5442-8abb-7531edb89b29@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1394 bytes --]
On Wed, Jan 29, 2020 at 12:20:09PM +0530, Nagarjuna Kristam wrote:
>
>
> On 28-01-2020 23:40, Thierry Reding wrote:
> > > struct tegra_xudc_save_regs saved_regs;
> > > bool suspended;
> > > bool powergated;
> > > - struct usb_phy *usbphy;
> > > + struct usb_phy **usbphy;
> > > + int current_phy_index;
> > Can be unsigned int. It's also very long. It might be better to choose a
> > shorter name so that when you use it, the lines don't get excessively
> > long. Alternatively you could keep this field name and instead declare
> > local variables to reference the current PHY to make lines shorter.
> >
> > Actually, looking at this a bit more, I don't see current_phy_index ever
> > used by itself (other than the assignment and one check to see if a PHY
> > has been selected). So why not just store a pointer to the current PHY
> > and avoid all the dereferencing?
> >
> > Thierry
>
> current_phy_index main purpose is to quickly get which index for USB 2 and 3
> phy's to be used. This is used at mulitple functions. Based on your comment
> above, I believe its good to use 2 pointers for UTMI and USB 3 phy's, which
> are points to current phy index. This ensures to keep line length as less as
> possible.
Yes, I think in general it's preferable to use the objects directly
rather than an index into an array to find the objects.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-01-29 9:27 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-30 11:09 [Patch V3 00/18] Tegra XUSB OTG support Nagarjuna Kristam
2019-12-30 11:09 ` [Patch V3 01/18] dt-bindings: phy: tegra-xusb: Add usb-role-switch Nagarjuna Kristam
2020-01-04 0:37 ` Rob Herring
2019-12-30 11:09 ` [Patch V3 02/18] dt-bindings: usb: Add NVIDIA Tegra XUSB device mode controller binding Nagarjuna Kristam
2019-12-30 11:09 ` [Patch V3 03/18] phy: tegra: xusb: Add usb-role-switch support Nagarjuna Kristam
2020-01-28 17:32 ` Thierry Reding
2020-01-29 9:15 ` Nagarjuna Kristam
2020-01-29 9:26 ` Thierry Reding
2019-12-30 11:09 ` [Patch V3 04/18] phy: tegra: xusb: Add usb-phy support Nagarjuna Kristam
2020-01-28 17:38 ` Thierry Reding
2019-12-30 11:09 ` [Patch V3 05/18] phy: tegra: xusb: Add support to get companion USB 3 port Nagarjuna Kristam
2020-01-28 17:40 ` Thierry Reding
2019-12-30 11:09 ` [Patch V3 06/18] phy: tegra: xusb: Add set_mode support for USB 2 phy on Tegra210 Nagarjuna Kristam
2020-01-28 17:41 ` Thierry Reding
2019-12-30 11:09 ` [Patch V3 07/18] phy: tegra: xusb: Add set_mode support for utmi phy on Tegra186 Nagarjuna Kristam
2020-01-28 17:45 ` Thierry Reding
2019-12-30 11:09 ` [Patch V3 08/18] usb: xhci-tegra: Add OTG support Nagarjuna Kristam
2020-01-28 17:54 ` Thierry Reding
2019-12-30 11:09 ` [Patch V3 09/18] usb: gadget: tegra-xudc: Remove usb-role-switch support Nagarjuna Kristam
2020-01-28 17:58 ` Thierry Reding
2019-12-30 11:09 ` [Patch V3 10/18] usb: gadget: tegra-xudc: Add usb-phy support Nagarjuna Kristam
2020-01-28 18:02 ` Thierry Reding
2019-12-30 11:09 ` [Patch V3 11/18] usb: gadget: tegra-xudc: use phy_set_mode to set/unset device mode Nagarjuna Kristam
2020-01-28 18:03 ` Thierry Reding
2019-12-30 11:09 ` [Patch V3 12/18] usb: gadget: tegra-xudc: support multiple device modes Nagarjuna Kristam
2020-01-28 18:10 ` Thierry Reding
2020-01-29 6:50 ` Nagarjuna Kristam
2020-01-29 9:27 ` Thierry Reding [this message]
2019-12-30 11:09 ` [Patch V3 13/18] arm64: tegra: update OTG port entries for jetson-tx1 Nagarjuna Kristam
2019-12-30 11:09 ` [Patch V3 14/18] arm64: tegra: update OTG port entries for jetson-tx2 Nagarjuna Kristam
2019-12-30 11:09 ` [Patch V3 15/18] arm64: tegra: Add xudc node for Tegra210 Nagarjuna Kristam
2019-12-30 11:09 ` [Patch V3 16/18] arm64: tegra: Enable xudc on Jetson TX1 Nagarjuna Kristam
2019-12-30 11:09 ` [Patch V3 17/18] arm64: tegra: Add xudc node for Tegra186 Nagarjuna Kristam
2019-12-30 11:09 ` [Patch V3 18/18] arm64: tegra: Enable xudc node on Jetson TX2 Nagarjuna Kristam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200129092728.GB2479935@ulmo \
--to=thierry.reding@gmail.com \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nkristam@nvidia.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).