From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: Chen-Yu Tsai <wens@csie.org>,
dri-devel@lists.freedesktop.org,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Daniel Vetter <daniel.vetter@intel.com>,
David Airlie <airlied@linux.ie>,
devicetree@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/4] drm/of: Change the prototype of drm_of_lvds_get_dual_link_pixel_order
Date: Wed, 2 Sep 2020 03:10:09 +0300 [thread overview]
Message-ID: <20200902001009.GC14351@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200901132340.tahqsx3sknl47ile@gilmour.lan>
Hi Maxime,
On Tue, Sep 01, 2020 at 03:23:40PM +0200, Maxime Ripard wrote:
> On Mon, Aug 31, 2020 at 11:28:52PM +0300, Laurent Pinchart wrote:
> > On Thu, Jul 30, 2020 at 11:35:01AM +0200, Maxime Ripard wrote:
> > > The drm_of_lvds_get_dual_link_pixel_order() function took so far the
> > > device_node of the two ports used together to make up a dual-link LVDS
> > > output.
> > >
> > > This assumes that a binding would use an entire port for the LVDS output.
> > > However, some bindings have used endpoints instead and thus we need to
> > > operate at the endpoint level. Change slightly the arguments to allow that.
> >
> > Is this still needed ? Unless I'm mistaken, the Allwinner platform now
> > uses two TCON instances for the two links, so there are two ports.
>
> Yes, and no.
>
> The two TCONs indeed have each a port of their own, so we do have two
> ports indeed. However, what we don't have is a port entirely dedicated
> to the LVDS output.
>
> Our binding uses a single port for all its output (RGB, LVDS or TV/HDMI
> controllers) with different endpoints.
Good point. Then let's keep this patch :-) We can't fix existing
bindings, but for the future, let's model separate display outputs as
ports, not endpoints.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2020-09-02 0:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 9:35 [PATCH v2 0/4] drm/sun4i: Add support for dual-link LVDS on the A20 Maxime Ripard
2020-07-30 9:35 ` [PATCH v2 1/4] drm/of: Change the prototype of drm_of_lvds_get_dual_link_pixel_order Maxime Ripard
2020-08-31 20:28 ` Laurent Pinchart
2020-09-01 13:23 ` Maxime Ripard
2020-09-02 0:10 ` Laurent Pinchart [this message]
2020-07-30 9:35 ` [PATCH v2 2/4] drm/sun4i: tcon: Refactor the LVDS and panel probing Maxime Ripard
2020-08-29 6:43 ` Chen-Yu Tsai
2020-10-05 14:18 ` Maxime Ripard
2020-10-05 14:28 ` Chen-Yu Tsai
2020-08-31 20:38 ` Laurent Pinchart
2020-07-30 9:35 ` [PATCH v2 3/4] drm/sun4i: tcon: Support the LVDS Dual-Link on the A20 Maxime Ripard
2020-08-29 6:55 ` Chen-Yu Tsai
2020-08-31 20:43 ` Laurent Pinchart
2020-07-30 9:35 ` [PATCH v2 4/4] [DO NOT MERGE] ARM: dts: sun7i: Enable LVDS Dual-Link on the Cubieboard Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200902001009.GC14351@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=daniel.vetter@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=frowand.list@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mark.rutland@arm.com \
--cc=maxime@cerno.tech \
--cc=robh+dt@kernel.org \
--cc=tzimmermann@suse.de \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).