From: Rob Herring <robh@kernel.org>
To: Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
hyesoo.yu@samsung.com, david@redhat.com, mhocko@suse.com,
surenb@google.com, pullip.cho@samsung.com, joaodias@google.com,
hridya@google.com, john.stultz@linaro.org,
sumit.semwal@linaro.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, hch@infradead.org,
linaro-mm-sig@lists.linaro.org
Subject: Re: [PATCH v3 3/4] dt-bindings: reserved-memory: Make DMA-BUF CMA heap DT-configurable
Date: Thu, 14 Jan 2021 08:01:38 -0600 [thread overview]
Message-ID: <20210114140138.GA2796092@robh.at.kernel.org> (raw)
In-Reply-To: <20210113012143.1201105-4-minchan@kernel.org>
On Tue, Jan 12, 2021 at 05:21:42PM -0800, Minchan Kim wrote:
> From: Hyesoo Yu <hyesoo.yu@samsung.com>
>
> Document devicetree binding for chunk cma heap on dma heap framework.
>
> The DMA chunk heap supports the bulk allocation of higher order pages.
Why do we need this? What does this do that CMA doesn't?
With a CMA area I can believe a carve out is a common, OS independent
thing. This looks too closely tied to some Linux thing to go into DT.
>
> Signed-off-by: Hyesoo Yu <hyesoo.yu@samsung.com>
> Signed-off-by: Minchan Kim <minchan@kernel.org>
> Signed-off-by: Hridya Valsaraju <hridya@google.com>
> Change-Id: I8fb231e5a8360e2d8f65947e155b12aa664dde01
Drop this.
> ---
> .../reserved-memory/dma_heap_chunk.yaml | 58 +++++++++++++++++++
> 1 file changed, 58 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/reserved-memory/dma_heap_chunk.yaml
>
> diff --git a/Documentation/devicetree/bindings/reserved-memory/dma_heap_chunk.yaml b/Documentation/devicetree/bindings/reserved-memory/dma_heap_chunk.yaml
> new file mode 100644
> index 000000000000..3e7fed5fb006
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/reserved-memory/dma_heap_chunk.yaml
> @@ -0,0 +1,58 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/reserved-memory/dma_heap_chunk.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Device tree binding for chunk heap on DMA HEAP FRAMEWORK
> +
> +description: |
> + The DMA chunk heap is backed by the Contiguous Memory Allocator (CMA) and
> + supports bulk allocation of fixed size pages.
> +
> +maintainers:
> + - Hyesoo Yu <hyesoo.yu@samsung.com>
> + - John Stultz <john.stultz@linaro.org>
> + - Minchan Kim <minchan@kernel.org>
> + - Hridya Valsaraju<hridya@google.com>
space ^
> +
> +
> +properties:
> + compatible:
> + enum:
> + - dma_heap,chunk
The format is <vendor>,<something> and 'dma_heap' is not a vendor.
> +
> + chunk-order:
> + description: |
> + order of pages that will get allocated from the chunk DMA heap.
> + maxItems: 1
> +
> + size:
> + maxItems: 1
> +
> + alignment:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - size
> + - alignment
> + - chunk-order
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + reserved-memory {
> + #address-cells = <2>;
> + #size-cells = <1>;
> +
> + chunk_memory: chunk_memory {
> + compatible = "dma_heap,chunk";
> + size = <0x3000000>;
> + alignment = <0x0 0x00010000>;
> + chunk-order = <4>;
> + };
> + };
> +
> +
> --
> 2.30.0.284.gd98b1dd5eaa7-goog
>
next prev parent reply other threads:[~2021-01-14 14:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 1:21 [PATCH v3 0/4] Chunk Heap Support on DMA-HEAP Minchan Kim
2021-01-13 1:21 ` [PATCH v3 1/4] mm: cma: introduce gfp flag in cma_alloc instead of no_warn Minchan Kim
2021-01-20 21:08 ` Suren Baghdasaryan
2021-01-13 1:21 ` [PATCH v3 2/4] mm: failfast mode with __GFP_NORETRY in alloc_contig_range Minchan Kim
2021-01-13 8:39 ` David Hildenbrand
2021-01-14 18:04 ` Minchan Kim
2021-01-13 1:21 ` [PATCH v3 3/4] dt-bindings: reserved-memory: Make DMA-BUF CMA heap DT-configurable Minchan Kim
2021-01-13 15:45 ` Rob Herring
2021-01-13 17:30 ` Hridya Valsaraju
2021-01-14 14:01 ` Rob Herring [this message]
2021-01-14 19:49 ` Hridya Valsaraju
2021-01-13 1:21 ` [PATCH v3 4/4] dma-buf: heaps: add chunk heap to dmabuf heaps Minchan Kim
2021-01-13 3:38 ` Randy Dunlap
2021-01-14 1:04 ` Minchan Kim
2021-01-19 15:51 ` Minchan Kim
2021-01-19 18:29 ` John Stultz
2021-01-19 20:36 ` Minchan Kim
2021-01-20 3:32 ` Hyesoo Yu
2021-01-20 20:53 ` Suren Baghdasaryan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210114140138.GA2796092@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=hch@infradead.org \
--cc=hridya@google.com \
--cc=hyesoo.yu@samsung.com \
--cc=joaodias@google.com \
--cc=john.stultz@linaro.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=pullip.cho@samsung.com \
--cc=sumit.semwal@linaro.org \
--cc=surenb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).