From: Kyle Tso <kyletso@google.com>
To: linux@roeck-us.net, heikki.krogerus@linux.intel.com,
gregkh@linuxfoundation.org, robh+dt@kernel.org,
hdegoede@redhat.com, badhri@google.com
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, Kyle Tso <kyletso@google.com>
Subject: [PATCH 0/3] common SVDM version and VDO from dt
Date: Tue, 26 Jan 2021 16:45:41 +0800 [thread overview]
Message-ID: <20210126084544.682641-1-kyletso@google.com> (raw)
The correct SVDM version we should use is the lowest common version
between the port partners (plug) as stated in the PD3 Spec 6.4.4.2.3.
It is determined in the Discovery Identity command so cache it and set
the value to the version field of the VDM header in every later SVDM.
Like the previous patch "usb: typec: tcpm: Create legacy PDOs for PD2
connection"
(https://lore.kernel.org/linux-usb/20210115163311.391332-1-kyletso@google.com/)
The field is changed before sending it out of the port. I know this is
not a good idea but at least it works.
The other two patches are about to get the VDO from fwnode so as to give
more flexibility.
Kyle Tso (3):
usb: typec: Determine common SVDM Versions
dt-bindings: connector: Add SVDM VDO properties
usb: typec: tcpm: Get Sink VDO from fwnode
drivers/usb/typec/altmodes/displayport.c | 6 ++-
drivers/usb/typec/class.c | 8 ++--
drivers/usb/typec/tcpm/tcpm.c | 56 ++++++++++++++++++++----
drivers/usb/typec/ucsi/displayport.c | 12 +++--
include/dt-bindings/usb/pd.h | 53 +++++++++++++++++++++-
include/linux/usb/pd_vdo.h | 40 ++++++++++++-----
6 files changed, 147 insertions(+), 28 deletions(-)
--
2.30.0.280.ga3ce27912f-goog
next reply other threads:[~2021-01-26 17:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 8:45 Kyle Tso [this message]
2021-01-26 8:45 ` [PATCH 1/3] usb: typec: Determine common SVDM Versions Kyle Tso
2021-01-26 15:07 ` Guenter Roeck
2021-01-26 8:45 ` [PATCH 2/3] dt-bindings: connector: Add SVDM VDO properties Kyle Tso
2021-01-26 15:15 ` Guenter Roeck
2021-01-26 8:45 ` [PATCH 3/3] usb: typec: tcpm: Get Sink VDO from fwnode Kyle Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210126084544.682641-1-kyletso@google.com \
--to=kyletso@google.com \
--cc=badhri@google.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).