From: Rob Herring <robh@kernel.org>
To: Jacopo Mondi <jacopo+renesas@jmondi.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/7] dt-bindings: media: max9286: Define 'maxim,gpio-poc'
Date: Thu, 15 Apr 2021 11:53:09 -0500 [thread overview]
Message-ID: <20210415165309.GA1535842@robh.at.kernel.org> (raw)
In-Reply-To: <20210415122602.87697-3-jacopo+renesas@jmondi.org>
On Thu, Apr 15, 2021 at 02:25:57PM +0200, Jacopo Mondi wrote:
> Define a new vendor property in the maxim,max9286 binding schema.
>
> The new property allows to declare that the remote camera
> power-over-coax is controlled by one of the MAX9286 gpio lines.
>
> As it is currently not possible to establish a regulator as consumer
> of the MAX9286 gpio controller for this purpose, the property allows to
> declare that the camera power is controlled by the MAX9286 directly.
>
> The property accepts a gpio-index (0 or 1) and one line polarity
> flag as defined by dt-bindings/gpio/gpio.h.
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> ---
> .../bindings/media/i2c/maxim,max9286.yaml | 71 ++++++++++++++++++-
> 1 file changed, 70 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml b/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml
> index 0e7162998b77..e2422241b7d0 100644
> --- a/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml
> @@ -70,6 +70,28 @@ properties:
> a remote serializer whose high-threshold noise immunity is not enabled
> is 100000 micro volts
>
> + maxim,gpio-poc:
> + $ref: '/schemas/types.yaml#/definitions/uint32-array'
> + minItems: 2
> + maxItems: 2
> + description: |
> + Index of the MAX9286 gpio output line (0 or 1) that controls Power over
> + Coax to the cameras and its associated polarity flag.
> +
> + The property accepts an array of two unsigned integers, the first being
> + the gpio line index (0 or 1) and the second being the gpio line polarity
> + flag (GPIO_ACTIVE_HIGH or GPIO_ACTIVE_LOW) as defined in
> + <include/dt-bindings/gpio/gpio.h>.
> +
> + When the remote cameras power is controlled by one of the MAX9286 gpio
> + lines, this property has to be used to specify which line among the two
> + available ones controls the remote camera power enablement.
> +
> + When this property is used it is not possible to register a gpio
> + controller as the gpio lines are controlled directly by the MAX9286 and
> + not available for consumers, nor the 'poc-supply' property should be
> + specified.
> +
> ports:
> $ref: /schemas/graph.yaml#/properties/ports
>
> @@ -182,7 +204,20 @@ required:
> - reg
> - ports
> - i2c-mux
> - - gpio-controller
> +
> +# If 'maxim,gpio-poc' is present, then 'poc-supply' and 'gpio-controller'
> +# are not allowed.
> +if:
> + required:
> + - maxim,gpio-poc
> +then:
> + allOf:
> + - not:
> + required:
> + - poc-supply
> + - not:
> + required:
> + - gpio-controller
I did tell you to do it this way on irc, but looking at it again, it's
slightly more concise to do:
properties:
poc-supply: false
gpio-controller: false
Note that 'properties' in the 'if' doesn't work because a schema
for a property evaluates as true when the property is not present.
Either way,
Reviewed-by: Rob Herring <robh@kernel.org>
Rob
next prev parent reply other threads:[~2021-04-15 16:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 12:25 [PATCH v4 0/7] arm64: dts: renesas: Enable GMSL on R8A77970 V3M Eagle Jacopo Mondi
2021-04-15 12:25 ` [PATCH v4 1/7] dt-bindings: media: max9286: Re-indent example Jacopo Mondi
2021-04-15 14:42 ` Laurent Pinchart
2021-04-15 16:40 ` Rob Herring
2021-04-15 12:25 ` [PATCH v4 2/7] dt-bindings: media: max9286: Define 'maxim,gpio-poc' Jacopo Mondi
2021-04-15 16:53 ` Rob Herring [this message]
2021-04-15 12:25 ` [PATCH v4 3/7] media: i2c: max9286: Use "maxim,gpio-poc" property Jacopo Mondi
2021-04-15 19:19 ` Laurent Pinchart
2021-04-18 15:01 ` Jacopo Mondi
2021-04-15 12:25 ` [PATCH v4 4/7] arm64: dts: renesas: r8a77970: Add csi40 port@0 Jacopo Mondi
2021-04-15 14:47 ` Laurent Pinchart
2021-04-15 16:47 ` Geert Uytterhoeven
2021-04-15 19:09 ` Laurent Pinchart
2021-04-15 12:26 ` [PATCH v4 5/7] arm64: dts: renesas: eagle: Enable MAX9286 Jacopo Mondi
2021-04-15 12:26 ` [PATCH v4 6/7] arm64: dts: renesas: eagle: Add GMSL .dtsi Jacopo Mondi
2021-04-15 12:26 ` [PATCH v4 7/7] DNI: arm64: dts: renesas: eagle: Include eagle-gmsl Jacopo Mondi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210415165309.GA1535842@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=jacopo+renesas@jmondi.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).