From: Jonathan Cameron <jic23@kernel.org>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: lee.jones@linaro.org, robh+dt@kernel.org, lars@metafoo.de,
sre@kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
linux-pm@vger.kernel.org, leonard.crestez@nxp.com,
letux-kernel@openphoenux.org
Subject: Re: [PATCH 1/4] dt-bindings: mfd: ricoh,rn5t618: ADC related nodes and properties
Date: Sat, 3 Jul 2021 17:02:45 +0100 [thread overview]
Message-ID: <20210703170245.1d310342@jic23-huawei> (raw)
In-Reply-To: <20210703084224.31623-2-andreas@kemnade.info>
On Sat, 3 Jul 2021 10:42:21 +0200
Andreas Kemnade <andreas@kemnade.info> wrote:
> Add ADC related nodes and properties. This will allow to wire
> up ADC channels to consumers, especially to measure input voltages
> by the power subdevice.
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
> .../bindings/mfd/ricoh,rn5t618.yaml | 53 +++++++++++++++++++
> 1 file changed, 53 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/ricoh,rn5t618.yaml b/Documentation/devicetree/bindings/mfd/ricoh,rn5t618.yaml
> index 032a7fb0b4a7..185f87a14a54 100644
> --- a/Documentation/devicetree/bindings/mfd/ricoh,rn5t618.yaml
> +++ b/Documentation/devicetree/bindings/mfd/ricoh,rn5t618.yaml
> @@ -73,6 +73,48 @@ properties:
> description: |
> See Documentation/devicetree/bindings/power/power-controller.txt
>
> + adc:
> + type: object
> +
> + properties:
> + compatible:
> + enum:
> + - ricoh,rn5t618-adc
> + - ricoh,rc5t619-adc
> +
> + "#io-channel-cells":
> + const: 1
> +
> + additionalProperties: false
> +
> + required:
> + - compatible
> + - "#io-channel-cells"
Strictly required? If not used below (where it is optional)
then why do we require the ADC driver to provided the services?
I don't mind you leave it as it is though if you prefer - it doesn't
do any harm!
> +
> + power:
> + type: object
> +
> + properties:
> + compatible:
> + enum:
> + - ricoh,rn5t618-power
> + - ricoh,rc5t619-power
> +
> + io-channels:
> + items:
> + - description: ADP Voltage Channel
> + - description: USB Voltage Channel
> +
> + io-channel-names:
> + items:
> + - const: vadp
> + - const: vusb
> +
> + additionalProperties: false
> +
> + required:
> + - compatible
> +
> regulators:
> type: object
>
> @@ -96,6 +138,17 @@ examples:
> interrupts = <11 IRQ_TYPE_EDGE_FALLING>;
> system-power-controller;
>
> + rn5t618_adc: adc {
> + compatible = "ricoh,rn5t618-adc";
> + #io-channel-cells = <1>;
> + };
> +
> + power {
> + compatible = "ricoh,rn5t618-power";
> + io-channels = <&rn5t618_adc 2>, <&rn5t618_adc 3>;
> + io-channel-names = "vadp", "vusb";
> + };
> +
> regulators {
> DCDC1 {
> regulator-min-microvolt = <1050000>;
next prev parent reply other threads:[~2021-07-03 16:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-03 8:42 [PATCH 0/4] mfd: rn5t618: Extend ADC support Andreas Kemnade
2021-07-03 8:42 ` [PATCH 1/4] dt-bindings: mfd: ricoh,rn5t618: ADC related nodes and properties Andreas Kemnade
2021-07-03 16:02 ` Jonathan Cameron [this message]
2021-07-03 16:43 ` Andreas Kemnade
2021-07-12 14:41 ` Rob Herring
2021-07-03 8:42 ` [PATCH 2/4] mfd: rn5t618: Add of compatibles for ADC and power Andreas Kemnade
2021-07-03 16:04 ` Jonathan Cameron
2021-07-03 16:31 ` Andreas Kemnade
2021-07-04 16:17 ` Jonathan Cameron
2021-07-05 7:36 ` Lee Jones
2021-07-05 8:31 ` Jonathan Cameron
2021-07-05 10:03 ` Andreas Kemnade
2021-07-05 7:37 ` Lee Jones
2021-07-03 8:42 ` [PATCH 3/4] iio: rn5t618: Add devicetree support Andreas Kemnade
2021-07-03 16:12 ` Jonathan Cameron
2021-07-03 8:42 ` [PATCH 4/4] power: supply: rn5t618: Add voltage_now property Andreas Kemnade
2021-07-03 11:41 ` kernel test robot
2021-07-03 14:35 ` kernel test robot
2021-07-03 15:29 ` Andreas Kemnade
2021-07-03 16:12 ` Jonathan Cameron
2021-07-03 15:59 ` [PATCH 0/4] mfd: rn5t618: Extend ADC support Jonathan Cameron
2021-07-03 16:39 ` Andreas Kemnade
2021-07-03 16:55 ` [Letux-kernel] " Andreas Kemnade
2021-07-04 16:10 ` Jonathan Cameron
2021-07-05 11:18 ` Andreas Kemnade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210703170245.1d310342@jic23-huawei \
--to=jic23@kernel.org \
--cc=andreas@kemnade.info \
--cc=devicetree@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=leonard.crestez@nxp.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).