From: "Marek Behún" <kabel@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, Vladimir Oltean <olteanv@gmail.com>,
Holger Brunck <holger.brunck@hitachienergy.com>,
Andrew Lunn <andrew@lunn.ch>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Russell King <rmk+kernel@armlinux.org.uk>,
linux-phy@lists.infradead.org, Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@ti.com>
Subject: Re: [PATCH devicetree 2/2] dt-bindings: phy: Add `tx-amplitude-microvolt` property binding
Date: Wed, 12 Jan 2022 18:29:00 +0100 [thread overview]
Message-ID: <20220112182900.7054c4d9@thinkpad> (raw)
In-Reply-To: <YbplENKCcjCUdwke@robh.at.kernel.org>
Hello Rob,
On Wed, 15 Dec 2021 15:58:40 -0600
Rob Herring <robh@kernel.org> wrote:
> On Wed, Dec 15, 2021 at 12:34:32AM +0100, Marek Behún wrote:
> > Common PHYs often have the possibility to specify peak-to-peak voltage
> > on the differential pair - the default voltage sometimes needs to be
> > changed for a particular board.
>
> I can envision needing this, but I can't say that I've seen custom
> properties being proposed for this purpose.
>
> >
> > Add properties `tx-amplitude-microvolt` and
> > `tx-amplitude-microvolt-names` for this purpose. The second property is
> > needed to specify
>
> Is the amplitude peak to peak? You just said it was, but perhaps make
> the property name more clearly defined: tx-p2p-microvolt
Yes, it is peak to peak.
> >
> > Example usage with only one voltage (it will be used for all supported
> > PHY modes, the `tx-amplitude-microvolt-names` property is not needed in
> > this case):
> >
> > tx-amplitude-microvolt = <915000>;
> >
> > Example usage with voltages for multiple modes:
> >
> > tx-amplitude-microvolt = <915000>, <1100000>, <1200000>;
> > tx-amplitude-microvolt-names = "2500base-x", "usb", "pcie";
>
> I'm not wild about the -names, but I think outside of ethernet most
> cases will only be 1 entry.
>
> For a phy provider with multiple phys, what if each one needs a
> different voltage (for the same mode)?
For such a provider I think the best way would be to have the different
PHYs each have a subnode:
phy-provider {
phy@0 {
tx-p2p-microvolt = ...;
};
}
>
> >
> > Signed-off-by: Marek Behún <kabel@kernel.org>
> > ---
> >
> > I wanted to constrain the values allowed in the
> > `tx-amplitude-microvolt-names` property to:
> > - ethernet SerDes modes (sgmii, qsgmii, 10gbase-r, 2500base-x, ...)
> > - PCIe modes (pattern: ^pcie[1-6]?$)
> > - USB modes (pattern: ^usb((-host|-device|-otg)?-(ls|fs|hs|ss|ss\+|4))?$)
> > - DisplayPort modes (pattern: ^dp(-rbr|-hbr[23]?|-uhbr-(10|13.5|20))?$)
> > - Camera modes (mipi-dphy, mipi-dphy-univ, mipi-dphy-v2.5-univ)
> > - Storage modes (sata, ufs-hs, ufs-hs-a, ufs-hs-b)
> >
> > But was unable to. The '-names' suffix implies string-array type, and
> > string-array type does not allow to specify a type for all items in a
> > simple way, i.e.:
> > items:
> > enum:
> > - sgmii
> > - sata
> > - usb
> > ...
>
> Works here: Documentation/devicetree/bindings/arm/samsung/pmu.yaml:56
>
> The requirement is you need to constrain the size with maxItems. It can
> be a 'should be enough for anyone' value.
Thx.
Marek
prev parent reply other threads:[~2022-01-12 17:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-14 23:34 [PATCH devicetree 0/2] Common PHY to YAML + tx-amplitude property Marek Behún
2021-12-14 23:34 ` [PATCH devicetree 1/2] dt-bindings: phy: Convert generic PHY provider binding to YAML Marek Behún
2021-12-15 21:41 ` Rob Herring
2021-12-14 23:34 ` [PATCH devicetree 2/2] dt-bindings: phy: Add `tx-amplitude-microvolt` property binding Marek Behún
2021-12-15 10:55 ` Andrew Lunn
2021-12-15 17:22 ` Marek Behún
2021-12-15 17:29 ` Andrew Lunn
2021-12-15 22:01 ` Rob Herring
2021-12-15 21:58 ` Rob Herring
2022-01-12 17:29 ` Marek Behún [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220112182900.7054c4d9@thinkpad \
--to=kabel@kernel.org \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=holger.brunck@hitachienergy.com \
--cc=kishon@ti.com \
--cc=linux-phy@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).