From: Bill Mills <bill.mills@linaro.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Frank Rowand <frowand.list@gmail.com>,
Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kbuild@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
anmar.oueja@linaro.org, Masahiro Yamada <masahiroy@kernel.org>
Subject: Re: [PATCH] of: unittest: Statically apply overlays using fdtoverlay
Date: Tue, 12 Jan 2021 05:16:54 -0500 [thread overview]
Message-ID: <4a8bbbaa-9303-8a8c-1de4-38499b8151dd@linaro.org> (raw)
In-Reply-To: <20210112083703.yfpicoi4zrddeykd@vireshk-i7>
On 1/12/21 3:37 AM, Viresh Kumar wrote:
> On 11-01-21, 20:22, Bill Mills wrote:
>> On 1/11/21 5:06 PM, Frank Rowand wrote:
>>> NACK to this specific patch, in its current form.
>>>
>>> There are restrictions on applying an overlay at runtime that do not apply
>>> to applying an overlay to an FDT that will be loaded by the kernel during
>>> early boot. Thus the unittest overlays _must_ be applied using the kernel
>>> overlay loading methods to test the kernel runtime overlay loading feature.
>>>
>>> I agree that testing fdtoverlay is a good idea. I have not looked at the
>>> parent project to see how much testing of fdtoverlay occurs there, but I
>>> would prefer that fdtoverlay tests reside in the parent project if practical
>>> and reasonable. If there is some reason that some fdtoverlay tests are
>>> more practical in the Linux kernel repository then I am open to adding
>>> them to the Linux kernel tree.
>
> I wasn't looking to add any testing for fdtoverlay in the kernel, but
> then I stumbled upon unit-tests here and thought it would be a good
> idea to get this built using static tools as well, as we aren't
> required to add any new source files for this and the existing tests
> already cover a lot of nodes.
>
> And so I am fine if we don't want to do this stuff in kernel.
>
>> I thought we were aligned that any new overlays into the kernel today would
>> only be for boot loader applied case. Applying overlays at kernel runtime
>> was out of scope at your request.
>>
>> Rob had requested that the overlays be test applied at build time. I don't
>> think there is any way to test the kernel runtime method at build time
>> correct?
>>
>> Please clarify your concern and your suggested way forward.
>
> The kernel does some overlay testing currently (at kernel boot only,
> not later), to see if the overlays get applied correctly or not, these
> are the unit tests.
>
> What Frank is probably saying is that the unit-tests dtbs shouldn't
> get used for testing fdtoverlay stuff. He isn't asking to support
> runtime application of overlays, but to not do fdtoverlay testing in
> the kernel.
>
Thanks Viresh, that makes sense. Sorry for the confusion Frank.
--
Bill Mills
next prev parent reply other threads:[~2021-01-12 10:17 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 5:15 [PATCH V2 1/2] scripts: dtc: Add fdtoverlay.c and fdtdump.c to DTC_SOURCE Viresh Kumar
2021-01-07 5:15 ` [PATCH V2 2/2] scripts: dtc: Build fdtoverlay and fdtdump tools Viresh Kumar
2021-01-07 5:45 ` Masahiro Yamada
2021-01-07 6:25 ` [PATCH V3 " Viresh Kumar
2021-01-12 0:44 ` Frank Rowand
2021-01-12 5:08 ` Viresh Kumar
2021-01-12 18:34 ` Frank Rowand
2021-01-13 4:55 ` Viresh Kumar
2021-01-12 0:55 ` Frank Rowand
2021-01-12 4:48 ` Viresh Kumar
2021-01-19 16:28 ` [PATCH V2 " Frank Rowand
2021-01-19 16:34 ` Frank Rowand
2021-01-08 8:41 ` [PATCH] of: unittest: Statically apply overlays using fdtoverlay Viresh Kumar
2021-01-11 15:46 ` Rob Herring
2021-01-11 22:09 ` Frank Rowand
2021-01-14 5:03 ` Viresh Kumar
2021-01-14 15:01 ` Rob Herring
2021-01-15 5:44 ` Viresh Kumar
2021-01-18 3:54 ` Frank Rowand
2021-01-19 2:30 ` Frank Rowand
2021-01-18 6:30 ` David Gibson
2021-01-19 2:29 ` Frank Rowand
2021-01-11 22:06 ` Frank Rowand
2021-01-12 1:22 ` Bill Mills
2021-01-12 8:37 ` Viresh Kumar
2021-01-12 10:16 ` Bill Mills [this message]
2021-01-12 18:17 ` Frank Rowand
2021-01-12 14:04 ` Rob Herring
2021-01-12 19:06 ` Frank Rowand
2021-01-12 19:41 ` Rob Herring
2021-01-12 20:05 ` Frank Rowand
2021-01-12 20:46 ` Rob Herring
2021-01-13 2:20 ` Frank Rowand
2021-01-13 15:05 ` Rob Herring
2021-01-13 17:21 ` Frank Rowand
2021-01-14 5:00 ` Viresh Kumar
2021-01-19 2:25 ` Frank Rowand
2021-01-19 2:21 ` frowand.list
2021-01-19 8:05 ` Viresh Kumar
2021-01-19 15:44 ` Frank Rowand
2021-01-20 5:06 ` Viresh Kumar
2021-01-20 6:20 ` Viresh Kumar
2021-01-21 5:00 ` Frank Rowand
2021-01-21 5:09 ` Viresh Kumar
2021-01-21 6:41 ` David Gibson
2021-01-11 22:13 ` [PATCH V2 1/2] scripts: dtc: Add fdtoverlay.c and fdtdump.c to DTC_SOURCE Frank Rowand
2021-01-12 4:45 ` Viresh Kumar
2021-01-19 16:21 ` Frank Rowand
2021-01-19 16:31 ` Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a8bbbaa-9303-8a8c-1de4-38499b8151dd@linaro.org \
--to=bill.mills@linaro.org \
--cc=anmar.oueja@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=pantelis.antoniou@konsulko.com \
--cc=robh+dt@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).