From: Paul Murphy <paul.j.murphy@linux.intel.com>
To: Daniele Alessandrelli <daniele.alessandrelli@linux.intel.com>,
Sudeep Holla <sudeep.holla@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Jassi Brar <jassisinghbrar@gmail.com>,
Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
Paul Murphy <paul.j.murphy@intel.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Dinh Nguyen <dinguyen@kernel.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/7] mailbox: keembay-scmi-mailbox: Add support for Keem Bay mailbox
Date: Thu, 9 Jul 2020 14:28:10 +0100 [thread overview]
Message-ID: <537a4c$cobr4j@orsmga004-auth.jf.intel.com> (raw)
In-Reply-To: <491f994c6f87a542e49fe37c8a75ab46f1b3712b.camel@linux.intel.com>
On 7/9/20 13:23, Daniele Alessandrelli wrote:
> Hi Sudeep,
>
> Thanks for your review.
>
> On Wed, 2020-07-08 at 21:34 +0100, Sudeep Holla wrote:
>> On Tue, Jun 16, 2020 at 04:56:08PM +0100, Daniele Alessandrelli
>> wrote:
>>> From: Paul Murphy <paul.j.murphy@intel.com>
>>>
>>> Keem Bay SoC has a ARM trusted firmware-based secure monitor which
>>> acts
>>> as the SCP for the purposes of power management over SCMI.
>>>
>>> This driver implements the transport layer for SCMI to function.
>>>
>> Please use the smc transport support in
>> driver/firmware/arm_scmi/smc.c
>> for this. You don't need mailbox support for SMC/HVC. Basically you
>> don't need this driver at all and you have everything you need to
>> support
>> what you want.
>>
>> Let me know if you face issues.
>>
> Sorry, we didn't know about the SMC transport support for SCMI. Looks
> like it was added only recently, while our driver was already developed
> and waiting to be upstreamed.
>
> I agree that we can drop this driver and switch to the SMC transport as
> you suggested, but I think we'll have to modify our bootloader SiP
> service slightly. Paul, can you elaborate?
>
Just one question.
In our patch, we pass the shared memory address as the second argument
of the SiP service, as it means we don't have to hardcode that in our
firmware. Sudeep, do you know if it was intentional in
smc_send_message() to leave that out? If we leave it out, we are
requiring the secure monitor to hardcode the shared memory address.
Regards,
Paul
next prev parent reply other threads:[~2020-07-09 13:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 15:56 [PATCH 0/7] Add initial Keem Bay SoC / Board support Daniele Alessandrelli
2020-06-16 15:56 ` [PATCH 1/7] dt-bindings: mailbox: Add Keem Bay SCMI mailbox bindings Daniele Alessandrelli
2020-07-08 20:40 ` Sudeep Holla
2020-06-16 15:56 ` [PATCH 2/7] mailbox: keembay-scmi-mailbox: Add support for Keem Bay mailbox Daniele Alessandrelli
2020-07-08 20:34 ` Sudeep Holla
2020-07-09 12:23 ` Daniele Alessandrelli
2020-07-09 13:28 ` Paul Murphy [this message]
2020-07-10 8:01 ` Sudeep Holla
2020-06-16 15:56 ` [PATCH 3/7] arm64: Add config for Keem Bay SoC Daniele Alessandrelli
2020-06-16 15:56 ` [PATCH 4/7] dt-bindings: arm: Add Keem Bay bindings Daniele Alessandrelli
2020-06-16 15:56 ` [PATCH 5/7] MAINTAINERS: Add maintainers for Keem Bay SoC Daniele Alessandrelli
2020-06-16 15:56 ` [PATCH 6/7] arm64: dts: keembay: Add device tree " Daniele Alessandrelli
2020-07-08 20:39 ` Sudeep Holla
2020-06-16 15:56 ` [PATCH 7/7] arm64: dts: keembay: Add device tree for Keem Bay EVM board Daniele Alessandrelli
2020-06-30 7:07 ` [PATCH 0/7] Add initial Keem Bay SoC / Board support Daniele Alessandrelli
2020-07-06 4:36 ` Jassi Brar
2020-07-07 21:17 ` Daniele Alessandrelli
2020-07-07 23:44 ` Jassi Brar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='537a4c$cobr4j@orsmga004-auth.jf.intel.com' \
--to=paul.j.murphy@linux.intel.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=daniele.alessandrelli@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=paul.j.murphy@intel.com \
--cc=robh+dt@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).