From: Sricharan R <sricharan@codeaurora.org>
To: Abhishek Sahu <absahu@codeaurora.org>
Cc: mark.rutland@arm.com, robh@kernel.org,
devicetree@vger.kernel.org, catalin.marinas@arm.com,
will.deacon@arm.com, linux@armlinux.org.uk,
bjorn.andersson@linaro.org, david.brown@linaro.org,
robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, andy.gross@linaro.org,
linux-arm-msm-owner@vger.kernel.org, linux-soc@vger.kernel.org,
sboyd@codeaurora.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/15] ARM: dts: ipq4019: Add ipq4019-ap.dk04.dtsi
Date: Tue, 6 Feb 2018 11:31:10 +0530 [thread overview]
Message-ID: <65ec9aef-c712-b8de-8da0-c1211ea0fbb3@codeaurora.org> (raw)
In-Reply-To: <a32d3a776c7a3f5c88a9a26200bff915@codeaurora.org>
Hi Abhishek,
On 2/3/2018 4:47 PM, Abhishek Sahu wrote:
> On 2018-01-29 10:41, Sricharan R wrote:
>> Add the common parts for the dk04 boards.
>>
>> Signed-off-by: Sricharan R <sricharan@codeaurora.org>
>> ---
>> arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1.dtsi | 147
>
> <snip>
>> +
>> + nand_pins: nand_pins {
>> + pullups {
>> + pins = "gpio52", "gpio53",
>> "gpio58",
>> + "gpio59";
>> + function = "qpic";
>> + bias-pull-up;
>> + };
>> +
>> + pulldowns {
>> + pins = "gpio54", "gpio55",
>> "gpio56",
>> + "gpio57", "gpio60",
>> "gpio61",
>> + "gpio62", "gpio63",
>> "gpio64",
>> + "gpio65", "gpio66",
>> "gpio67",
>> + "gpio68", "gpio69";
>> + function = "qpic";
>> + bias-pull-down;
>> + };
>> + };
>
> Can you please check once why do we need pull-up and
> pull-down for NAND pins. The NAND chip will be mounted
> over board itself so board design should take care of
> required pull up and pull downs.
>
Mostly because, these are always **weak** pull up/down as defaults
and should be overridden by the ones in the board (if there).
> Also, some of the above pins like gpio52 will be only used
> for LCD so we can remove those pins. Later on, when LCD
> support will be added, we can add those pins.
ok
Regards,
Sricharan
--
"QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2018-02-06 6:01 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-29 5:11 [PATCH 00/15] ARM: dts: ipq: updates to enable a few peripherals Sricharan R
2018-01-29 5:11 ` [PATCH 01/15] firmware: qcom: scm: Add ipq4019 soc compatible Sricharan R
2018-02-05 6:07 ` Rob Herring
2018-02-06 4:46 ` Sricharan R
2018-01-29 5:11 ` [PATCH 02/15] ARM: dts: ipq4019: Add a few peripheral nodes Sricharan R
2018-01-29 5:11 ` [PATCH 03/15] ARM: dts: ipq4019: Change the max opp frequency Sricharan R
2018-01-29 5:11 ` [PATCH 04/15] ARM: dts: ipq4019: Update ipq4019-dk01.1 board data Sricharan R
2018-01-29 5:11 ` [PATCH 05/15] ARM: dts: ipq4019: Add ipq4019-ap-dk01-c2 board file Sricharan R
[not found] ` <1517202689-14212-6-git-send-email-sricharan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-02-03 10:55 ` Abhishek Sahu
2018-02-06 5:55 ` Sricharan R
2018-01-29 5:11 ` [PATCH 06/15] ARM: dts: ipq4019: Add ipq4019-ap.dk04.dtsi Sricharan R
[not found] ` <1517202689-14212-7-git-send-email-sricharan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-02-03 11:17 ` Abhishek Sahu
2018-02-06 6:01 ` Sricharan R [this message]
2018-01-29 5:11 ` [PATCH 07/15] ARM: dts: ipq4019: Add ipq4019-ap.dk04.1-c1 board file Sricharan R
[not found] ` <1517202689-14212-8-git-send-email-sricharan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-02-03 11:30 ` Abhishek Sahu
[not found] ` <6821d93c282c8337b2a58c5c9337a008-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-02-06 6:18 ` Sricharan R
[not found] ` <1517202689-14212-1-git-send-email-sricharan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-01-29 5:11 ` [PATCH 08/15] ARM: dts: ipq4019: Add qcom-ipq4019-ap.dk04.1-c5 " Sricharan R
[not found] ` <1517202689-14212-9-git-send-email-sricharan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-02-03 11:33 ` Abhishek Sahu
2018-01-29 5:11 ` [PATCH 09/15] ARM: dts: ipq4019: Add qcom-ipq4019-ap.dk04.1-c3 " Sricharan R
2018-02-03 11:37 ` Abhishek Sahu
[not found] ` <4a173ff2a74ed7d1555d52674cf64ddd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-02-06 6:27 ` Sricharan R
2018-01-29 5:11 ` [PATCH 10/15] ARM: dts: ipq4019: Add ipq4019-ap.dk07.1 common data Sricharan R
2018-01-29 5:11 ` [PATCH 11/15] ARM: dts: ipq4019: Add qcom-ipq4019-ap.dk07.1-c1 board file Sricharan R
2018-01-29 5:11 ` [PATCH 12/15] ARM: dts: ipq4019: Add qcom-ipq4019-ap.dk07.1-c2 " Sricharan R
2018-02-03 12:13 ` Abhishek Sahu
[not found] ` <033a420e14f090258e4c8f14b7ba89a7-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-02-07 4:00 ` Sricharan R
2018-01-29 5:11 ` [PATCH 13/15] ARM: dts: ipq8074: Add peripheral nodes Sricharan R
2018-01-29 5:11 ` [PATCH 14/15] ARM: dts: ipq8074: Add pcie nodes Sricharan R
2018-02-01 0:51 ` kbuild test robot
2018-01-29 5:11 ` [PATCH 15/15] ARM: dts: ipq8074: Enable few peripherals for hk01 board Sricharan R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65ec9aef-c712-b8de-8da0-c1211ea0fbb3@codeaurora.org \
--to=sricharan@codeaurora.org \
--cc=absahu@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm-owner@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).