From: John Garry <john.garry@huawei.com>
To: bhelgaas@google.com
Cc: mika.westerberg@linux.intel.com, rafael@kernel.org,
lorenzo.pieralisi@arm.com, rjw@rjwysocki.net, robh+dt@kernel.org,
arnd@arndb.de, mark.rutland@arm.com, olof@lixom.net,
hanjun.guo@linaro.org, dann.frazier@canonical.com,
benh@kernel.crashing.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org, linuxarm@huawei.com,
linux-pci@vger.kernel.org, minyard@acm.org,
devicetree@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [PATCH v11 2/9] PCI: Remove unused __weak attribute in pci_register_io_range()
Date: Mon, 22 Jan 2018 11:59:20 +0000 [thread overview]
Message-ID: <6816e715-df0f-ddff-d19d-de2d0f3101c7@huawei.com> (raw)
In-Reply-To: <1516537647-50553-3-git-send-email-john.garry@huawei.com>
On 21/01/2018 12:27, John Garry wrote:
> From: Gabriele Paoloni <gabriele.paoloni@huawei.com>
>
> Currently pci_register_io_range() has only one definition;
> therefore there is no use of the __weak attribute.
>
> Signed-off-by: Gabriele Paoloni <gabriele.paoloni@huawei.com>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
Hi Bjorn,
So I will need to respin this series again (and it still requires many
more SOB tags), so do you want to pick up this minor patch in isolation
now? It would save me carrying it, and save people receiving it in future.
Thanks,
John
> drivers/pci/pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index 764ca7b..d8357ff 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -3383,7 +3383,7 @@ struct io_range {
> * Record the PCI IO range (expressed as CPU physical address + size).
> * Return a negative value if an error has occured, zero otherwise
> */
> -int __weak pci_register_io_range(phys_addr_t addr, resource_size_t size)
> +int pci_register_io_range(phys_addr_t addr, resource_size_t size)
> {
> int err = 0;
>
>
next prev parent reply other threads:[~2018-01-22 11:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-21 12:27 [PATCH v11 0/9] LPC: legacy ISA I/O support John Garry
2018-01-21 12:27 ` [PATCH v11 1/9] LIB: Introduce a generic PIO mapping method John Garry
2018-01-21 13:17 ` kbuild test robot
2018-01-21 13:29 ` kbuild test robot
[not found] ` <1516537647-50553-1-git-send-email-john.garry-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2018-01-21 12:27 ` [PATCH v11 2/9] PCI: Remove unused __weak attribute in pci_register_io_range() John Garry
2018-01-22 11:59 ` John Garry [this message]
2018-01-21 12:27 ` [PATCH v11 3/9] PCI: Add fwnode handler as input param of pci_register_io_range() John Garry
2018-01-21 12:27 ` [PATCH v11 4/9] PCI: Apply the new generic I/O management on PCI IO hosts John Garry
2018-01-21 12:27 ` [PATCH v11 5/9] OF: Add missing I/O range exception for indirect-IO devices John Garry
2018-01-21 14:04 ` kbuild test robot
2018-01-21 15:53 ` kbuild test robot
2018-01-21 12:27 ` [PATCH v11 6/9] LPC: Support the LPC host on Hip06/Hip07 with DT bindings John Garry
2018-01-21 17:54 ` Randy Dunlap
2018-01-22 10:13 ` John Garry
2018-01-21 12:27 ` [PATCH v11 7/9] ACPI: Translate the I/O range of non-MMIO devices before scanning John Garry
2018-01-21 12:27 ` [PATCH v11 8/9] LPC, ACPI: Add the HISI LPC ACPI support John Garry
2018-01-21 12:27 ` [PATCH v11 9/9] MAINTAINERS: Add maintainer for HiSilicon LPC driver John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6816e715-df0f-ddff-d19d-de2d0f3101c7@huawei.com \
--to=john.garry@huawei.com \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=dann.frazier@canonical.com \
--cc=devicetree@vger.kernel.org \
--cc=hanjun.guo@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=minyard@acm.org \
--cc=olof@lixom.net \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).